Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Selection - Output Panel] Selection extended to the current opened file #28609

Closed
warpdesign opened this issue Jun 13, 2017 · 2 comments
Closed

[Selection - Output Panel] Selection extended to the current opened file #28609

warpdesign opened this issue Jun 13, 2017 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
June 2017

Comments

@warpdesign
Copy link
Contributor

  • VSCode Version: insiders bbcd10...
  • OS Version: Window 10 (insiders)

Steps to Reproduce:

  1. Open a new file
  2. Open the bottom panel and select some text inside the terminal or output panel
  3. While maintaining left mouse button down, move the cursor on the left, over the sidebar

What happens?
Some text is selected in the currently opened file, above the output panel

What should happen?
Selection shouldn't extend to the opened editor

vscode_selection
@vscodebot vscodebot bot added the insiders label Jun 13, 2017
@ramya-rao-a ramya-rao-a added the terminal Integrated terminal issues label Jun 13, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 13, 2017

Upstream PR for this is out xtermjs/xterm.js#700

@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jun 13, 2017
@Tyriar Tyriar added this to the June 2017 milestone Jun 13, 2017
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jun 13, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 13, 2017

I merged it into our release branch, fix should come tomorrow.

@Tyriar Tyriar closed this as completed Jun 13, 2017
Tyriar added a commit that referenced this issue Jun 13, 2017
@Tyriar
Uplevel xterm.js
5e70c18 
Fixes #23142
Fixes #28609
@alexdima alexdima added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
4 participants
@warpdesign @Tyriar @alexdima @ramya-rao-a