Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sections in Extensions viewlet #28663

Closed
sandy081 opened this issue Jun 13, 2017 · 9 comments
Closed

Support sections in Extensions viewlet #28663

sandy081 opened this issue Jun 13, 2017 · 9 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Support sections in Extensions viewlet

  • Recommended
  • Installed
@sandy081 sandy081 self-assigned this Jun 13, 2017
@sandy081 sandy081 added extensions Issues concerning extensions feature-request Request for new features or functionality labels Jun 13, 2017
@sandy081 sandy081 added this to the June 2017 milestone Jun 13, 2017
@sandy081
Copy link
Member Author

kapture 2017-06-21 at 2 16 41

@sandy081
Copy link
Member Author

To verify:

  • Installed and Recommended sections are shown by default (when Search box is empty)
  • While searching from Marketplace, a single section showing extensions from Marketplace are shown

@jrieken jrieken added the verified Verification succeeded label Jun 28, 2017
@ghiscoding
Copy link

@sandy081 I know this subject is closed but I'm not sure if I should open a new issue for this or not. I would have preferred to have the "Recommended" on top instead of "Installed". Why? Simply because the search, which is just over the "installed" is making this confusing since it searches through the market place (not through the installed ones) and the recommended do come from the market place so it's less confusing (in my mind anyway).

@sandy081
Copy link
Member Author

@ghiscoding Agreed that not everybody wants to have Installed section on the top which is the feedback I received from few. With July milestone, you can reorder your sections. Please refer to #30120

@kzhui125
Copy link

1

Maybe it's better not to recommend extensions under start 3 ?

@sandy081
Copy link
Member Author

@KING66 not sure if I understand your comment. Do you mean not to show the recommended sections at all?

@kzhui125
Copy link

@sandy081 I mean Code recommend a extension which has 2.5 star....
1

@sandy081
Copy link
Member Author

@KING66 Its not based on stars but we have a set of extensions recommended for languages / file patterns. Also a workspace can define recommendations.

@kzhui125
Copy link

kzhui125 commented Jul 12, 2017

@sandy081 got it, thanks for your reply.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants