Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated Terminal: Multiline Urls are not handled correctly #28746

Closed
webdeb opened this issue Jun 14, 2017 · 3 comments
Closed

Integrated Terminal: Multiline Urls are not handled correctly #28746

webdeb opened this issue Jun 14, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@webdeb
Copy link

webdeb commented Jun 14, 2017

  • VSCode Version:
    Version 1.13.0 (1.13.0)
  • OS Version:
    OSX - Sierra
    Steps to Reproduce:
  1. Open vscode integrated terminal
  2. Produce an URL which has a line-break inside the console (this for example could be the output of git push with the merge-request creation link, but you can simulate it by just typing an URL basically, has the same effect)
  3. Try to click on it with CMD+Click
  • Expected result:

Full URL is parsed correctly

  • Actual result:

Only the part, which is on the 1. line is parsed as the URL

image

NOTE: In iTerm its working as expected

bildschirmfoto 2017-06-14 um 22 41 35

@ramya-rao-a ramya-rao-a added the terminal Integrated terminal issues label Jun 14, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2017

Upstream issue: xtermjs/xterm.js#24

@Tyriar
Copy link
Member

Tyriar commented Mar 9, 2018

I just pushed in support for this, there are currently the following known issues:

  1. The prompt may or may not be "linkified", this depends on how the linefeed was added to the terminal. For example up to browse history may not work
  2. Printing a long link and then reducing the width of the terminal will cause the underline to go much larger than desired. This should be fixed when reflow is implemented Reflow terminal lines when resized #23688

@Tyriar
Copy link
Member

Tyriar commented Mar 30, 2018

There are a few issues with multi-line link support still which should get resolved when we tackle reflow #23688

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants