Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: tree and list aria-posinset and aria-setsize #29172

Closed
2 tasks done
isidorn opened this issue Jun 21, 2017 · 3 comments
Closed
2 tasks done

Test: tree and list aria-posinset and aria-setsize #29172

isidorn opened this issue Jun 21, 2017 · 3 comments
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues testplan-item
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 21, 2017

Complexity: 2

Refs: #27900

We have added the aria-posinset and aria-setsize attributes to the list and quick open. By using developer tools inspect those HTML elements and verify these attributes are really there and they have appropriate values. You should also use a screen reader however I am not 100% sure how this should be reflected on a screen reader.

Examples where we use the list in vscode: extensions list, suggest widget.
To inspect quickOpen use this workbench setting "workbench.quickOpen.closeOnFocusLost": false

@joaomoreno feel free to edit

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues testplan-item labels Jun 21, 2017
@isidorn isidorn added this to the June 2017 milestone Jun 21, 2017
@roblourens
Copy link
Member

I can't figure out how to get nvda to read "x of y" labels, but the aria attributes appear to be set correctly.

@roblourens roblourens removed their assignment Jun 27, 2017
@ramya-rao-a
Copy link
Contributor

@isidorn Are we to test both list and tree controls?

The title of this test item refers to both, description refers to only list control.

List controls in extension list has the required aria labels
Tree control in quick open has the required aria labels
But tree control in search results doesnt have the required labels.
I am guessing this is by design, but wanted to confirm nevertheless

@ramya-rao-a ramya-rao-a removed their assignment Jun 27, 2017
@isidorn
Copy link
Contributor Author

isidorn commented Jun 28, 2017

@ramya-rao-a yes, this is by design, sorry for not being more clear. For the tree we have implemented this only in quick open and we should check it there
@roblourens yes I am also not sure how to make nvda read that out, I think it is some special nvda command

Thanks for testing

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues testplan-item
Projects
None yet
Development

No branches or pull requests

4 participants