Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug repl / Exception widget: link detector is not multi-root fit #29190

Closed
bpasero opened this issue Jun 21, 2017 · 7 comments
Closed

Debug repl / Exception widget: link detector is not multi-root fit #29190

bpasero opened this issue Jun 21, 2017 · 7 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues workbench-multiroot Multi-root (multiple folders) issues

Comments

@bpasero
Copy link
Member

bpasero commented Jun 21, 2017

There is a call to contextService.toResource() which cannot work once you are in a multi root environment. In that case, the link can only be converted if the root folder is known where it should resolve to.

@bpasero bpasero added debug Debug viewlet, configurations, breakpoints, adapter issues workbench-multiroot Multi-root (multiple folders) issues labels Jun 21, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 21, 2017

@michelkaporin can you look into this? It would also be a good introduction to the multi root universe?

@isidorn isidorn assigned michelkaporin and unassigned isidorn Jun 21, 2017
@michelkaporin
Copy link
Contributor

@isidorn will do 👍

@michelkaporin
Copy link
Contributor

@bpasero how urgent is this? Should I jump on it before the endgame?

@isidorn
Copy link
Contributor

isidorn commented Jun 22, 2017

@michelkaporin not for this milestone, it would be great if you look into it in july. Of course if you already have cycles you can start on it but no rush

@isidorn isidorn added this to the July 2017 milestone Jun 22, 2017
@michelkaporin
Copy link
Contributor

@isidorn ok, will do it in July then 👍

@michelkaporin
Copy link
Contributor

@isidorn didn't have time, sorry. Thanks for picking that up.

@isidorn isidorn modified the milestones: September 2017, August 2017 Aug 30, 2017
@bpasero bpasero changed the title Debug repl: link detector is not multi-root fit Debug repl / Exception widget: link detector is not multi-root fit Sep 20, 2017
@isidorn
Copy link
Contributor

isidorn commented Sep 22, 2017

Relative file path detecting was not working properly so I decided to remove it.
Link detection needs a serios rewrite before we start adding new features

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants