Update from original (#1)

[deysaikat95]

• Using node 7.9.0

• Using node 7.9.0

• untitledEditorInput: title and description

• undo explorerView-change

• fix merge breakage

• add _workbench.pickWorkspace command

• always use uri.toString() when comparing uris for equality

• introduce resources.dirname, fixes label in no-tab view

• add todo@remote tags

• don't let the file service track editors, let the file tracker do it

• first check for file-schema and then call super, send activation event for others

• scm: show actions, display focus

• splitview: dont save layout size

• scm: typo

• scm: more actions

• Closes showTextDocument & vscode.diff always default to ViewColumn.One #27408 - Adds ViewColumn.Active

• find in folder only for local folders

• a somewhat sane way to know how to open a file

• ftp: fix drag and drop

• fix npe

• 💄

• 💄

• pickWorkspace => pickWorkspaceFolder

• Fix markdown table of contents name for strings like # ff

Fixes #34644

• Update .tsx import statement snippet to be consistent with .ts (Update .tsx import statement snippet to be consistent with .ts #34653)

Fixes #34646

• Implement Report specific error data when an extension installation fails #34659

• Report specific error data when an extension installation fails #34659 Use error code in uninstall event

• Run --export-default-configuration with fresh user-data-dir and extensions-dir

• Pick up latest TS 2.5.3 insiders

Fixes #33972

• Uplevel xterm.js

Fixes #34493
Fixes #34563

• Replace duplicated textSpan conversion logic

• Continue moving range/position conversion to single location

• Continue moving vs loc to ts loc location into single set of functions

• Fix terminal mouse coordinate issues

Fixes #34184

• Uplevel xterm.js

See xtermjs/xterm.js#990

• git: leverage new ViewColumn.Active

• fix npe

• introduce IWorkspaceFoldersChangeEvent for onDidChangeWorkspaceFolders (for Adding folder to workspace should reveal and expand that folder #31195)

• fix Is it expected that in 1.16, Hovers with null items in their arrays do not render at all #34520

• Use workbench state instead of checking on workspace config

• polish label

• Use workspace folder picker

• more fixes for cannot read property 'resourceJSON' of null #34490

• alex: first remove decoration types and only then fire a model change event

• Move indent ranges to ITokenizedModel

• add IModelLanguageConfigurationChangedEvent and ViewLanguageConfigurationEvent

• [folding] should not fold whitespace after function. Fixes [folding] should not fold whitespace after function #3353

• Test offSide indentRanges (for [folding] should not fold whitespace after function #3353)

• Fix merging issue with [folding] should not fold whitespace after function #3353

• remove some schema === 'file' checks

• explorer: expand root folder properly

fixes #31195

• fix bulb resolve for remote providers

• use IWorkspaceEditingServce to add workspace folder, support to store uris in the workspace file

• use more proper types for workspace on main side

• Revert "use IWorkspaceEditingServce to add workspace folder, support to store uris in the workspace file"

This reverts commit 89c4a71.

• explorerView: remove fsPath use

• remove usage of URI.file

#34296

• explorer: fix expand

• 💄

• views2 > panelViewlet

• fix [Multi-Repo] Deleting Git Repo on Disk Does Not Remove Repo From List #34645

• Delete comment out

• call addFolder when a provider adds a new root

• Workspace folder picker command (for We should have a workspace folder picker API in the Extension host #32936) (Workspace folder picker command (for #32936) #34648)

• Workspace folder picker command (for We should have a workspace folder picker API in the Extension host #32936)

• fix test

• make this proper API

• Rename to IWorkspaceFolder

• Move toResource method to IWorkspaceFolder

• add index to IPickOpenItem

• add missing create options

• createFile errors when file is already there

• Fix Select-Object highlighting issue.

• Fix Support URIs in Workspace Configuration Files #34699

• 💄

• Also listen to folders change event

• have TrieMap and StringTrieMap for more flex

• Fixes workspaceContains starts a search over full workspace, including .git/, node_modules/ #34487

• fix bad merge

• Fix Settings: left hand side of folder settings should respect settings in that folder #31568

• Settings button does not support touch (fixes Settings button does not support touch #34678)

• Add import statement snippet to .js(x) files (Add import statement snippet to .js(x) files #34682)

• Add import statement snippet to JS files

This makes them consistent with TS files.

• Add import statement snippet to jsx files

• Fix The debug "launch" setting throws error when attempting to "Copy to Settings" #32593

• Adopt support for multiroot folders

• node-debug2@1.17.2

• Fixes webview eating esc key

Fixes #34612

• update bracket matching on language configuration change

• color space 0...1

• provideColorPresentations should have document in paramaters.

• Look only in default paths for recommendations (Avoid fssync calls in workbench in extensionTipsService #34528)

• Make display string optional in ts/js hover

• Add optional CompletionContext to provideCompletionItems

Fixes #752

Adds a new overload of provideCompletionItems that takes a context argument. This context is currently used to provide the trigger character of the suggestion

• Update based on comments

• Fix interfaces and move the function types into namespaces

• Take context as last argument

• Adding completion item kind enum

• Revert chnage to languages.test

• Add note about trigger character

• touch bar: reuse entries to avoid flickering

• debt - make vscode.Uri compatibile with URI, declare private ctor

• debt - move more static props out

• Fix Can't dismiss notification when focus is in the keyboard bindings editor #34403

• Cache content widgets dimensions (Poor resize performance for editor with many code lenses  #34716)

• add filters, API Request: Function for showing an "Open File" dialog that returns the selected path #13807

• add jsdoc, API Request: Function for showing an "Open File" dialog that returns the selected path #13807

• one more comment API Request: Function for showing an "Open File" dialog that returns the selected path #13807

• add --install-source to cli process

• fix context for commands run from touchbar

• UI polish for tasks in multi folder setup

• make room for full debug toolbar

• fix Cannot read property 'position' of null #34464

• Tweaks to content widgets renderings (Poor resize performance for editor with many code lenses  #34716)

• vscode.d.ts: add ColorPresentation constructor

• [css] move colorpresentations to language server

• clean up styler

• Fixes Tasks - Multiroot folder - no all detected tasks presented in quick pick #34732: Tasks - Multiroot folder - no all detected tasks presented in quick pick

• Fixes Occurrences highlighting gets removed after switching documents #34722: compute occurences when switching back to a file which had occurences

• better default config (for Changed/Deleted workspace should turn into untitled workspace #30864)

• Do not search for empty glob patterns (workspaceContains starts a search over full workspace, including .git/, node_modules/ #34487)

• modesContentHover: remove console log

• [json] provide colorpresentations in language server

• [html] provide colorpresentations in language server

• ensure that the scheme is 'file' detecting scripts

• debug: location of repl messages

fixes #24490

• Only paint the dirty image data rectangle (Expore improvements to minimap rendering performance #34170)

• Defer folder setup computation

• More code cleanup

• Removed () from folder name qualification

• allow workspaces with 0 folders (Investigate to support 0-folder workspaces #34622)

• add id to FileStat and remove resource, make readdir return tuples, sketch up error codes, add todos on the API

• operations that create a file/folder should return a stat-object because we want it anyways

• better error handling when resolving non-existent files, stop using async/await

• fix tests

• Fixes Task output - show the folder in which a task is running #31133: Task output - show the folder in which a task is running Task output - show the folder in which a task is running #31133

• debug: polish quick open entry label

• null check

fixes #34746

• Fixes Mulitline copy/pasting #11007: improve text that lands in the clipboard in the multicursor case

• save workspace is always enabled (Investigate to support 0-folder workspaces #34622)

• allow to define byte-offset and byte-count when reading from a provider

• "Start Without Debugging" doesn't work properly #34714

• Fixes Clean up from _readIsISOKeyboard change #34031: Remove workaround for Backslash and IntlBackslash "swapped" on ISO keyboards - ISO Keyboards: Backslash and IntlBackslash "swapped" #24153

• Sort extension based recommendations based on recommended date Extension recommended via prompt should show up higher in the recommended list #34233

• Recommend only if files exists

• Lowercase extension ids before check

• Cleaning up formatting provider to use async

• Move formatting options manager to own class

• Split formatting config manager to own file

• Don't export config from formatting config manager

• Move ts and js config manager into same object

• Rename to FormattingConfigurationManager

• Make sure we send format requests before code actions / refactor

• Include extensionId in telemetry event for recommendation popup

• Auto show path intellisense when typing ' or " in import statement

Fixes #23962

• Trigger intellisense on / in ts paths

• Add source when installing extension via uri

• Fix Extra indentation of def when prefixed with "private" #33939

• Add protected and private visibility keywords to increaseIndentPattern
• Remove when keyword from decreaseIndentPattern

• Also trigger completion items for require and import expressions

• Non standard Delimiter Used in title/Caption bar (fixes Non standard Delimiter Used in title/Caption bar #34742)

• clarify WorkspaceFolder#uri

• Fixes vscode.diff only allows selecting language for right-hand diff #34408: Have the mode picker change the mode for both models in the diff editor case

• [html] fix build error (shrinkwrap not uptodate)

• [html] update vscode-languageserver-types to 3.4.0

• fix CachedData dir won't clean up #34751

• tweak deprecation comment

• add perf-ticks for extensions handling

• breakpoint event 'update' for backward compatibility

• debug: fix adapterData being passed around

fixes #34511

• Given URI impl a more special name...

• log api usage for getWorkspaceFolder

• tweaks for class URI cannot represent relative file paths #34449

• debug: custom telemetry service should be per session

fixes Microsoft/vscode-internalbacklog#100

• move open/save api into stable api, API Request: Function for showing an "Open File" dialog that returns the selected path #13807

• workspace.openTextDocument works incorectly when passing { content?: string; } as argument (fix workspace.openTextDocument works incorectly when passing { content?: string; } as argument #34796)

• actually invoke a function... FTP polish #34704

• showWorkspaceFolderPick not enforced as proposed api (fixes showWorkspaceFolderPick not enforced as proposed api #34819)

• Fixes When computing the task definition key we should falsify undefined properties #31970: When computing the task definition key we should falsify undefined properties

• Fixes problemMatcher $tsc-watch ignores error second time around #34412: problemMatcher $tsc-watch ignores error second time around

• debug: remove fsPath usage

• debug: do not allow breakpoints in settings files always

#30996

• FoldingRules language configuration simplification

• [folding] fold regions, initial, preconfigured support. For [folding] fold regions #12146

• Introduce GlobPattern and adopt in DocumentFilter/FileWatcher/FileSearch (Introduce IRelativePattern and adopt in DocumentFilter/FileWatcher/FileSearch #34695)

• introduce IRelativePattern and use in extension API

• 💄

• docs

• introduce RelativePattern

• support RelativePattern also for file watcher

• also make findFiles support RelativePattern

• less type conversion

• add GlobPattern type and remove readonly

• make base a string

• fix setter access to RelativePattern

• fix npe when exclude is undefined

• fix findFiles: pattern seems to be matched against workspace always

• 💄

• clarify glob pattern matching

• 💄

• [folding] fix cpp regions

• 💄

• smoke: fix quick open focus issue

• explorerView: do not use filter: File

#34768

• read most of the encoding from stream

• debug: when constructiing source path take scheme into account

• better (the same we already have) binary file error

• workspace: remove fsPath

• 💄

• remote - refine utimes

• linkDetector: remove elative paths supported

fixes #29190

• move node cached data clean up into shared process

• Add a word or two about the query-argument, Allow language extensions to have consistent symbol matching for document and workspace #34605

• fix bogus compare of resource

• 💄

• smoke: dont use monaco-editor.focused

• smoke: dont use monaco-editor.focused

• smoke: dont use :focus selector

• smoke: add tracing message

• smoke: use debug inspector protocol

• node debug version bumps

• Use async in refactor provider

• Localize markdown preview title

Fixes #34830

• 2017-09-22. Merged in translations from Transifex.

• Autoshow suggestions for jsdoc param

Fixes #34853

• Telemetry to differentiate all recommendations view from the others

• Fix failing tests

• Update TS insiders version

• Prototype TSC watch task contribution (Prototype TSC watch task contribution #33865)

• Prototype TSC watch task contribution

• Update to make use of optional properties in task definitions

• Really fix test on options

• Add sourceInfo when installing from welcomePage or cli

• Check type of token that triggered the quick suggestions

Fixes #34863

Bug
Quick suggestions currently check the token at the cursor location to determine if we are in a string or comment. Because token spans are setup like: [start, end), this results in the incorrect token being checked when the quick suggestions are triggered immediatly before a comment or string

Fix
Check the token one index back from the cursor

• Enable proposed api in api-tests

• lookup files.encoding properly

• disable test on proposed API

• fix missing dirty diff decorations

• smoke: fix another focus issue

• Alternate fix for Dont trigger emmet when the value for a css property is being typed #34162 using minscore for fuzzymatching

• Trigger emmet completion for numbers Fixes Emmet snippets don't appear in the middle of CSS-rules block (.css files) #34877

• node-debug@1.17.11

• Fix Revisit usages of Uri#file #34296

• node-debug2@1.17.4

• Ensure ripgrep is killed when vscode exits, for Search Service consumes 70% of my CPU on startup for quite some time #34434

• touch bar: reuse groups

• Fix wrong path join in queryBuilder.ts

• better fix for workspace.openTextDocument works incorectly when passing { content?: string; } as argument #34796

• 💄

• Fixes VSCode duplicates Character When Using Special Characters in Mac OS #34826: write character before cursor to the textarea on OSX to allow the "long-press" composition to work

• Fix Do not show the info setting decorations in diff editor #34834

• handle missing product.commit, Cannot build on Fedora #34523

• mark commit as optional, Cannot build on Fedora #34523

• show console.log from extension host top frame in dev tools (Extensions: show location of console log in consoles #34936)

• remove profiling hint as it isn't reliable/valuable enough

• Fix We should only convert settings into the workspace settings section if certain preconditions are meet. #33670

[msftclas]

All CLA requirements met.