Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problemMatcher $tsc-watch ignores error second time around #34412

Closed
cloudkite opened this issue Sep 14, 2017 · 2 comments
Closed

problemMatcher $tsc-watch ignores error second time around #34412

cloudkite opened this issue Sep 14, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded

Comments

@cloudkite
Copy link

cloudkite commented Sep 14, 2017

  • VSCode Version: Code 1.16.1 (27492b6, 2017-09-14T16:24:39.530Z)
  • OS Version: Darwin x64 15.6.0
  • typescript version: 2.5.2

Given the following tasks.json which finds all typescript errors in project

// tasks.json
{
  "version": "2.0.0",
  "tasks": [
    {
      "taskName": "tsc-watch",
      "type": "shell",
      "command": "./node_modules/.bin/tsc",
      "args": ["--noEmit", "-w", "-p", "."],
      "presentation": {
        "echo": true,
        "reveal": "silent",
        "focus": false,
        "panel": "shared"
      },
      "group":{
        "kind": "build",
        "isDefault": true
      },
      "isBackground": true,
      "problemMatcher": "$tsc-watch"
    }
  ]
}

an index.ts file:

// index.ts
import related from './related';

console.log(related(1))

an related.ts file:

// related.ts
export default function related(thing: number) {
  return thing
}

Steps to reproduce.

  1. Open related.ts without index.ts open.
  2. Change thing: number to thing: string = vscode correctly shows 1 error
  3. Undo change = vscode correctly shows 0 errors
  4. Redo change in Step 2 = vscode incorrectly still shows 0 errors
@dbaeumer
Copy link
Member

@cloudkite very good catch.

I fixed this for the next insider build.

@cloudkite
Copy link
Author

@dbaeumer Awesome thanks for that! looking forward to the next build 👍

@aeschli aeschli added the verified Verification succeeded label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants