Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkifier gets confused with scrollback #990

Closed
mofux opened this issue Sep 13, 2017 · 0 comments
Closed

Linkifier gets confused with scrollback #990

mofux opened this issue Sep 13, 2017 · 0 comments
Labels
type/bug Something is misbehaving
Milestone
3.0.0

Comments

@mofux
Copy link
Contributor

mofux commented Sep 13, 2017

The linkifier seems to take the last link discovered in the scrollback and always print it to the last row.

Reproduce

  • start the demo
  • cat README.md
  • scroll up, until a linked row is at the very bottom of the viewport
  • click any link
  • scroll down until you reach the end
  • the last row of the viewport has a surprise ready for you. Hover it and it will be linkified (with underline on hover). Clicking it will open the link that was on the bottom row in step 3

linkify-bug
@mofux mofux changed the title Linkifier get confused with scrollback Linkifier gets confused with scrollback Sep 13, 2017
@mofux mofux added the type/bug Something is misbehaving label Sep 13, 2017
@mofux mofux added this to the 3.0.0 milestone Sep 13, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 20, 2017
@Tyriar
Properly clear links
8243eef 
MouzeZoneManager rows are not 0-based

Fixes xtermjs#990
@Tyriar Tyriar mentioned this issue Sep 20, 2017
Merged
Tyriar added a commit to microsoft/vscode that referenced this issue Sep 20, 2017
@Tyriar
Uplevel xterm.js
f7962f0 
See xtermjs/xterm.js#990
@deysaikat95 deysaikat95 mentioned this issue Sep 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@mofux