ExplorerView#getActiveFile only uses file-uris

[jrieken]

Trying to understand why remote files aren't reveal in the explorer brings me to this: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/browser/views/explorerView.ts#L363. Unclear why and why we don't try to lookup a uri in the explorer model?

[jrieken]

/cc @bpasero for clarification

[bpasero]

Yes I think this check is bogus now that other resources are shown in the explorer. The intent is to show and reveal the active file of the editor in the explorer. I think the explorer view model would be fit enough to deal with any schemes now.

[jrieken]

@isidorn Can we tackle this for September? I would make the demo nicer

[isidorn]

@jrieken yes, I can look into this today

[isidorn]

@bpasero looking at the code @jrieken pointed out it is enough to just remove filter: 'file'.
The only way to match the resource agains the explorerModel is to compare uri, thus I would first need to get a uri which defeats the purpose, since that is all we want.

[bpasero]

@isidorn I do not understand the problem, sorry.

[isidorn]

@bpasero sorry for not being clear. There is no problem, I just propse a fix which I just pushed 6dc90ea

Apart from this I question the use of a filter Shuold we try to remove this?

[bpasero]

@isidorn ah sorry, I read your last comment wrong. yes I think we need to revisit every use of this filter thing and make sure to get rid of it if possible.

[isidorn]

Ok I can look into the filter. My commit should fix this issue though -> closing

[jrieken]

Thanks Isi