Why do I get lightbulbs/refactorings on all quoted strings (among other things)?

[chrisdias]

I seem to get a lot of lightbulbs. For examaple, when I highlight the entire line here why am i getting a refactoring?

If i put the cursor in the 'docker' string I get a lightbulb:

I move the cursor to getConfiguration and the lightbulb goes away...

Actually, it looks like no matter where I have a quoted string, I get a lightbulb. Here my cursor is in "Images":

And when I tell it to refactor my code into a new function, I get this which is technically correct I guess, but not very useful as far as I can tell.

    private newFunction(): string {
        return "Images";
    }

[mjbvz]

This looks like a bug on our side for strings. The lightbulb should only show up when you either have a selection or when the cursor is in a range with a diagnostic of some kind

More broadly, we should really not support extracting literals like this at all. This is tracked upstream by microsoft/TypeScript#18060

[mjbvz]

Looks like insiders only. 1.16 not effected in my testing

@jrieken Was the intent to only keep in the #33241 empty selection fix for 1.16 and then revert it in master? (d8ec15e) If so, I'll push harder to get the TS fix in for TS 2.5.3 and see if we can inline the empty selection logic in the TS extension side for now

[jrieken]

Was the intent to only keep in the #33241 empty selection fix for 1.16 and then revert it in master? (d8ec15e) I

Yes. Having lightbulbs on empty selections is valid, think of a invert-if-else hint at the end of an if-statement, more here: #33241 (comment)

On the good side, the lightbulb oracle now uses the range of the selection (unless it's a diagnostics) and the provider can check how much is selected. E.g. I think it useful to offer 'extract method' when having a single statement selected, it should be at least 2 statements.