Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output: Cannot read property 'updateTitle' of undefined #34746

Closed
bpasero opened this issue Sep 21, 2017 · 5 comments
Closed

Output: Cannot read property 'updateTitle' of undefined #34746

bpasero opened this issue Sep 21, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug output Output channel system issues verified Verification succeeded

Comments

@bpasero
Copy link
Member

bpasero commented Sep 21, 2017

Found this in my console when running out of sources, not sure how I triggered it though:

shell.js:228 Cannot read property 'updateTitle' of undefined: TypeError: Cannot read property 'updateTitle' of undefined
    at PanelPart.CompositePart.updateTitle (file:///Users/bpasero/Development/monaco/out/vs/workbench/browser/parts/compositePart.js:252:28)
    at file:///Users/bpasero/Development/monaco/out/vs/workbench/browser/parts/compositePart.js:75:23
    at CompletePromise_ctor.CompletePromise_then [as then] (file:///Users/bpasero/Development/monaco/out/vs/base/common/winjs.base.raw.js:1566:49)
    at PanelPart.CompositePart.doOpenComposite (file:///Users/bpasero/Development/monaco/out/vs/workbench/browser/parts/compositePart.js:73:32)
    at PanelPart.CompositePart.openComposite (file:///Users/bpasero/Development/monaco/out/vs/workbench/browser/parts/compositePart.js:58:25)
    at file:///Users/bpasero/Development/monaco/out/vs/workbench/browser/parts/panel/panelPart.js:84:60
    at CompletePromise_ctor.CompletePromise_then [as then] (file:///Users/bpasero/Development/monaco/out/vs/base/common/winjs.base.raw.js:1566:49)
    at PanelPart.openPanel (file:///Users/bpasero/Development/monaco/out/vs/workbench/browser/parts/panel/panelPart.js:84:28)
    at OutputService.showOutput (file:///Users/bpasero/Development/monaco/out/vs/workbench/parts/output/browser/outputServices.js:180:38)
    at Object.show (file:///Users/bpasero/Development/monaco/out/vs/workbench/parts/output/browser/outputServices.js:120:67)

Maybe related to recent changes around multi root workspace support? CC @sandy081

@bpasero
Copy link
Member Author

bpasero commented Sep 21, 2017

@isidorn I can reproduce on every reload of the workbench, seems to be triggered by new code added from @dbaeumer (https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts#L1564) that appends output very early on startup.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug output Output channel system issues labels Sep 21, 2017
@dbaeumer
Copy link
Member

I can looking into postponing this a little...

@dbaeumer
Copy link
Member

Otherwise @jrieken gets after me :-)

@isidorn isidorn assigned dbaeumer and unassigned isidorn Sep 21, 2017
@dbaeumer
Copy link
Member

Done

@dbaeumer dbaeumer assigned isidorn and unassigned dbaeumer Sep 21, 2017
@dbaeumer
Copy link
Member

@isidorn assigning back to you to decide whether you want to fix this. Others might do something like this as well.

@isidorn isidorn added this to the September 2017 milestone Sep 21, 2017
@bpasero bpasero added the verified Verification succeeded label Sep 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug output Output channel system issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants