Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt settings in search to be folder scoped #29550

Closed
sandy081 opened this issue Jun 27, 2017 · 3 comments
Closed

Adopt settings in search to be folder scoped #29550

sandy081 opened this issue Jun 27, 2017 · 3 comments
Assignees
Labels
search Search widget and operation issues workbench-multiroot Multi-root (multiple folders) issues

Comments

@sandy081
Copy link
Member

Testing #29510

Following settings in Search can be customised at Folder level.

search.useIgnoreFilesByDefault
search.quickOpen.includeSymbols
@vscodebot vscodebot bot added the search Search widget and operation issues label Jun 27, 2017
@roblourens
Copy link
Member

I don't think useIgnoreFilesByDefault can be folder scoped, but includeSymbols probably makes sense.

@roblourens roblourens added the workbench-multiroot Multi-root (multiple folders) issues label Jun 28, 2017
@roblourens roblourens added this to the July 2017 milestone Jun 28, 2017
@bpasero
Copy link
Member

bpasero commented Jul 2, 2017

I am not 100% sure includeSymbols makes sense on a per-folder scope. The intent of the setting is to enable or disable having symbol search results showing up in normal file-quick open. It is not meant to be controlled per folder (e.g. as a way to exclude symbols from search results).

In other words, if we wanted to support this setting we would also need a similar setting to filter out symbol results in the symbol search in a similar way.

@roblourens roblourens removed this from the July 2017 milestone Jul 25, 2017
@roblourens
Copy link
Member

I agree, and I don't think there's actually any change to be made here.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
search Search widget and operation issues workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

3 participants