Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search in multiroot workspaces #29510

Closed
3 tasks done
roblourens opened this issue Jun 27, 2017 · 0 comments
Closed
3 tasks done

Search in multiroot workspaces #29510

roblourens opened this issue Jun 27, 2017 · 0 comments
Labels
testplan-item
Milestone
June 2017

Comments

@roblourens
Copy link
Member

roblourens commented Jun 27, 2017 •
edited by Tyriar
Loading

Complexity 3

This impacts

  • Search
  • Non-ripgrep search ("search.useRipgrep": false)
  • Quickopen

Please verify that in single and multi-root workspaces,

  • Search shows the correct results from all folders, with files.exclude and search.exclude settings correctly applied according to global settings, per-folder settings, "files to include/exclude" input boxes, and .gitignore files
  • The "find in folder" context menu in the files explorer sets up a search that only returns results from the selected folder
  • Quickopen respects the files.exclude settings and shows results from all folders
@vscodebot vscodebot bot added the search Search widget and operation issues label Jun 27, 2017
@roblourens roblourens added testplan-item and removed search Search widget and operation issues labels Jun 27, 2017
@roblourens roblourens added this to the June 2017 milestone Jun 27, 2017
@roblourens roblourens assigned isidorn, Tyriar and sandy081 and unassigned roblourens Jun 27, 2017
This was referenced Jun 27, 2017
Closed
Closed
Closed
Closed
@sandy081 sandy081 removed their assignment Jun 27, 2017
This was referenced Jun 27, 2017
Closed
Closed
Closed
@isidorn isidorn removed their assignment Jun 27, 2017
This was referenced Jun 27, 2017
Closed
Closed
@Tyriar Tyriar removed their assignment Jun 27, 2017
@Tyriar Tyriar closed this as completed Jun 27, 2017
This was referenced Jun 27, 2017
Closed
Closed
Closed
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testplan-item
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
4 participants
@roblourens @isidorn @Tyriar @sandy081