Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search include/exclude patterns are not applied to open files #29658

Closed
Tyriar opened this issue Jun 27, 2017 · 1 comment
Closed

Search include/exclude patterns are not applied to open files #29658

Tyriar opened this issue Jun 27, 2017 · 1 comment
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
July 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2017 •
edited
Loading

  • VSCode Version: Code - Insiders 1.14.0-insider (15b579d, 2017-06-27T05:11:33.154Z)
  • OS Version: Linux x64 4.10.0-24-generic
  • Extensions:
Extension Author (truncated) Version
EditorConfig Edi 0.9.3
lorem-ipsum Tyr 1.0.0
sort-lines Tyr 1.3.0
vscode-svgviewer css 1.4.2
tslint eg2 0.15.0
git-project-manager fel 1.3.2
md-navigate jri 0.0.1
vscode-scss mrm 0.6.2
seti-icons qin 0.1.3
vim vsc 0.9.0

(1 theme extensions excluded)

#29510

This only occurs when using ripgrep.

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Jun 27, 2017
@vscodebot vscodebot bot added the insiders label Jun 27, 2017
@roblourens
Copy link
Member

Not a regression from 1.13

@roblourens roblourens added this to the July 2017 milestone Jun 29, 2017
@roblourens roblourens changed the title Search results from settings.json get included even when files to include is specified Search include/exclude patterns are not applied to open files Jul 11, 2017
This was referenced Jul 11, 2017
Closed
Closed
This was referenced Jul 26, 2017
Closed
Closed
roblourens added a commit that referenced this issue Jul 30, 2017
@roblourens
Search include/exclude patterns are not applied to open files - fix #…
7a49b76 
…29658
@roblourens roblourens mentioned this issue Jul 31, 2017
Closed
@chrmarti chrmarti added the verified Verification succeeded label Aug 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
July 2017
Development

No branches or pull requests
3 participants
@roblourens @Tyriar @chrmarti