Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: find-in-files not excluding files.exclude folders #31459

Closed
frostius opened this issue Jul 26, 2017 · 2 comments
Closed

regression: find-in-files not excluding files.exclude folders #31459

frostius opened this issue Jul 26, 2017 · 2 comments
Assignees
@roblourens
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@frostius
Copy link

  • VSCode Version:1.14.2
  • OS Version:WIn 10

Find-in-files is not excluding folders in workspace settings files.exclude . Was working in 1.13

capture
@roblourens
Copy link
Member

The file is open, and exclude patterns don't apply to open files right now due to #29658

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 26, 2017
@frostius
Copy link
Author

Just to be clear, if by "the file is open" you are refering to the excluded file, this is not true - that file is not open. Do you mean that the search will match any file in any sub-folder that happens to match the base filename of any open file regardless of files.exclude?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @frostius