Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find: input not seeded with current selection #29712

Closed
egamma opened this issue Jun 28, 2017 · 0 comments · Fixed by #30351
Closed

Find: input not seeded with current selection #29712

egamma opened this issue Jun 28, 2017 · 0 comments · Fixed by #30351
Assignees
@Tyriar @mjbvz
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2017

Comments

@egamma
Copy link
Member

egamma commented Jun 28, 2017

Testing #29479

  • make a selection inside the terminal
  • type CTRL+F to pen the find widget

I would have expected that the find widget is seeded with the current selection, same as is done in the editor.
@vscodebot vscodebot bot added editor editor-find Editor find operations labels Jun 28, 2017
@egamma egamma added terminal General terminal issues that don't fall under another label and removed editor editor-find Editor find operations labels Jun 28, 2017
@Tyriar Tyriar added the feature-request Request for new features or functionality label Jun 28, 2017
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Jul 7, 2017
@mjbvz mjbvz self-assigned this Jul 10, 2017
mjbvz added a commit to mjbvz/vscode that referenced this issue Jul 10, 2017
@mjbvz
Seed terminal find widget with current selection
f3ce57a 
Fixes microsoft#29712

Use the current selection as the search when we first show the find widget for the terminal
@mjbvz mjbvz mentioned this issue Jul 10, 2017
Merged
@mjbvz mjbvz added this to the July 2017 milestone Jul 10, 2017
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Jul 10, 2017
mjbvz added a commit that referenced this issue Jul 10, 2017
@mjbvz
Seed terminal find widget with current selection (#30351)
5607d6b 
* Seed terminal find widget with current selection

Fixes #29712

Use the current selection as the search when we first show the find widget for the terminal

* Making requested changes
@roblourens roblourens added the verified Verification succeeded label Aug 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2017
Development

Successfully merging a pull request may close this issue.

Seed terminal find widget with current selection mjbvz/vscode
4 participants
@egamma @roblourens @Tyriar @mjbvz