-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[folding] Add fade in/out animation for folding arrows? #2984
Comments
@bgashler1 Assigning to you, Brad, to make a decision. If you like the suggestion, feel free to add, or assign back to me. |
@aeschli This is a great idea 👍 I can push it tomorrow before end of day my time, if that's not too late. Let me know. Otherwise, we'll definitely get it by March. |
@bgashler1 Feel free to deliver! |
Unfortunately, because we're using a parent hover technique, I don't believe it's possible to do a fade out. I think it's still valuable to do the fade in though—it makes things less abrupt. Hopefully we can figure out the fade out later, if it's possible. |
Assigning to @aeschli to verify. |
@bgashler1 I'm not understanding why fade out doesn't work. Seems like it would work fine since the parent isn't hiding or anything is it? |
Yeah, fade out is surely possible, pushed a change. Also sped up the opacity transition, it felt too slow. |
…s."" This reverts commit 20d655f.
The appearance/disappearance of the arrows is quite abrupt, a short fade similar to scroll bars would probably look nicer.
The text was updated successfully, but these errors were encountered: