Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] Add fade in/out animation for folding arrows? #2984

Closed
Tyriar opened this issue Feb 12, 2016 · 8 comments · Fixed by #3537
Closed

[folding] Add fade in/out animation for folding arrows? #2984

Tyriar opened this issue Feb 12, 2016 · 8 comments · Fixed by #3537
Assignees
Labels
editor-folding Editor code folding issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 12, 2016

The appearance/disappearance of the arrows is quite abrupt, a short fade similar to scroll bars would probably look nicer.

@egamma egamma added the editor label Feb 15, 2016
@aeschli aeschli changed the title Add fade in/out animation for folding arrows? [folding] Add fade in/out animation for folding arrows? Feb 22, 2016
@aeschli aeschli added the editor-folding Editor code folding issues label Feb 24, 2016
@aeschli aeschli assigned bgashler1 and unassigned aeschli Feb 24, 2016
@aeschli
Copy link
Contributor

aeschli commented Feb 24, 2016

@bgashler1 Assigning to you, Brad, to make a decision. If you like the suggestion, feel free to add, or assign back to me.

@aeschli aeschli added this to the Backlog milestone Feb 24, 2016
@bgashler1
Copy link
Contributor

@aeschli This is a great idea 👍 I can push it tomorrow before end of day my time, if that's not too late. Let me know. Otherwise, we'll definitely get it by March.

@aeschli
Copy link
Contributor

aeschli commented Feb 25, 2016

@bgashler1 Feel free to deliver!

@bgashler1
Copy link
Contributor

Unfortunately, because we're using a parent hover technique, I don't believe it's possible to do a fade out. I think it's still valuable to do the fade in though—it makes things less abrupt. Hopefully we can figure out the fade out later, if it's possible.

@bgashler1 bgashler1 assigned aeschli and unassigned bgashler1 Feb 26, 2016
@bgashler1
Copy link
Contributor

Assigning to @aeschli to verify.

@Tyriar
Copy link
Member Author

Tyriar commented Feb 26, 2016

@bgashler1 I'm not understanding why fade out doesn't work. Seems like it would work fine since the parent isn't hiding or anything is it?

joaomoreno added a commit that referenced this issue Feb 26, 2016
@joaomoreno
Copy link
Member

Yeah, fade out is surely possible, pushed a change. Also sped up the opacity transition, it felt too slow.

@joaomoreno joaomoreno modified the milestones: Feb 2016, Backlog Feb 26, 2016
aeschli added a commit that referenced this issue Feb 26, 2016
@joaomoreno joaomoreno modified the milestones: Backlog, Feb 2016 Feb 26, 2016
@joaomoreno joaomoreno assigned bgashler1 and unassigned aeschli Feb 26, 2016
@joaomoreno
Copy link
Member

We reverted the commits since the opacity also fades out the git diff decorations. See #3383. Reverted commits are b0ca83f and 20d655f.

Reopening, but not for February.

@joaomoreno joaomoreno reopened this Feb 26, 2016
tht13 added a commit to tht13/vscode that referenced this issue Feb 28, 2016
@joaomoreno joaomoreno assigned Tyriar and unassigned bgashler1 Jun 9, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-folding Editor code folding issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants