Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search viewlet multiroot UI #29977

Closed
roblourens opened this issue Jun 30, 2017 · 3 comments
Closed

Search viewlet multiroot UI #29977

roblourens opened this issue Jun 30, 2017 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan search Search widget and operation issues ux User experience issues
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Jun 30, 2017

We need to determine what the UI for multiroot searches in the search viewlet will look like, and experiment with different possibilities. This will be influenced in part by multiroot UI decisions elsewhere in the product.

Separate issue for functionality and include/exclude behavior in multi and single root workspaces: #27226

A few initial options:

  • Group results under a new node per root folder where the list still scrolls together (mostly implemented here: Group search results by root folders #29964 (comment))
  • Group results in subviews that scroll independently (git viewlet?)
  • Leave them in a flat list, but make the folder name stand out somehow
@vscodebot vscodebot bot added the search Search widget and operation issues label Jun 30, 2017
@roblourens roblourens added the feature-request Request for new features or functionality label Jun 30, 2017
@nicksnyder
Copy link
Contributor

Some thoughts:

Group results under a new node per root folder where the list still scrolls together (mostly implemented here: #29964 (comment))

I like that this UI allows you to clearly see which of your workspaces have results. It precludes interleaving results from different workspaces though.

Group results in subviews that scroll independently (git viewlet?)

N scroll views sounds clunky.

Leave them in a flat list, but make the folder name stand out somehow

This leaves open the option to interleave results from different repos. In practice, I am not sure what heuristic for sort order would be better than just grouping by repo (maybe just # of results per file?).

I would favor 1 or 3.

@glen-84
Copy link

glen-84 commented Jul 1, 2017

It might not be too complicated to offer both options (1 and 3), either with a setting or with a toggle button.

@bpasero
Copy link
Member

bpasero commented Jul 11, 2017

@roblourens I suggest we add this to our UX meetings (this week and/or next week).

@roblourens roblourens added the ux User experience issues label Jul 11, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan search Search widget and operation issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants