Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to choose theme variant (Gnome dark/light theme) #30031

Closed
jeremy447 opened this issue Jul 3, 2017 · 3 comments
Closed

Add a way to choose theme variant (Gnome dark/light theme) #30031

jeremy447 opened this issue Jul 3, 2017 · 3 comments
Labels
feature-request Request for new features or functionality linux Issues with VS Code on Linux *out-of-scope Posted issue is not in scope of VS Code themes Color theme issues workbench-electron Electron-VS Code issues

Comments

@jeremy447
Copy link

Hello,

The default Gnome theme Adwaita come with 2 variants. One light and one dark. Each app that implement the feature, like Gnome terminal, allow you to choose the theme variant in the preference. It will be awesome if we can do this in Vs Code.

screenshot from 2017-07-03 07-27-41

screenshot from 2017-07-03 07-28-14

screenshot from 2017-07-03 07-27-23

Thanks !

@vscodebot vscodebot bot added the workbench label Jul 3, 2017
@bpasero bpasero added the feature-request Request for new features or functionality label Jul 3, 2017
@bpasero bpasero removed their assignment Jul 3, 2017
@jeremy447
Copy link
Author

Shouldn't be hard to implement this since electron support this feature
electron/electron@058d0bb

@jeremy447
Copy link
Author

Like Gnome Terminal, the default theme should be the dark one.

@mjbvz mjbvz added the linux Issues with VS Code on Linux label Nov 3, 2017
@bpasero bpasero added themes Color theme issues workbench-electron Electron-VS Code issues and removed workbench labels Nov 16, 2017
@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label Dec 3, 2017
@vscodebot
Copy link

vscodebot bot commented Dec 3, 2017

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that have been on the backlog for a long time but have not gained traction: We look at the number of votes the issue has received and the number of duplicate issues filed. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Dec 3, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality linux Issues with VS Code on Linux *out-of-scope Posted issue is not in scope of VS Code themes Color theme issues workbench-electron Electron-VS Code issues
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @mjbvz @jeremy447 and others