Support dark theme in Gnome

[andreyorst]

• VSCode Version: 1.5
• OS Version: Linux

I do use light theme on my linux distribution, but in VScode i prefer standard dark theme for editor, so i desired to try to change a gtk theme for single window as i do often with several applications modifying their launchers and .desktop files, and had no success. As i figured out VScode doesn't use gtk for window decorations, so i tried xprop to change theme variant to dark. What i got is that window decoration changed to dark, but menu is still using old light style.

It would be great if VScode will start to use CSD (client side decorations) like in most native and not native gnome apps, so i request this feature too

Steps to Reproduce:
0. Use light gtk theme, that support dark variant, like Arc-GTK

1. Type in terminal: xprop -f _GTK_THEME_VARIANT 8u -set _GTK_THEME_VARIANT "dark"
2. Click VScode window
3. Notice that decorations turned to dark, but menu is still light
4. Cry.

[jhasse]

This would be a lot easier to fix when https://bugs.chromium.org/p/chromium/issues/detail?id=79722 is implemented. Especially client side decorations.

[bpasero]

@andreyorst does it help if you add the following option to the window creation in https://github.com/Microsoft/vscode/blob/master/src/vs/code/electron-main/window.ts#L162

darkTheme: true

See here how to build and run out of sources: https://github.com/Microsoft/vscode/wiki/How-to-Contribute

[harry-cpp]

electron/electron#2927

[Tyriar]

Chrome v59 uses gtk3 which hits the stable channel in June https://bugs.chromium.org/p/chromium/issues/detail?id=79722#c110 https://www.chromium.org/developers/calendar

[MattSturgeon]

Any update? It seems all the upstream blockers are gone now, but I can still reproduce this issue:

This isn't so bad with "window.menuBarVisibility": "toggle", but it is still an issue.

[harry-cpp]

@MattSturgeon Wrong, electron/electron#9946

[jeremy447]

This one #30031 is the same kind of request. It will allow us to use a dark variant without the hacky xprop way.

[harry-cpp]

Starting with GNOME 3.26 the "Global Dark Theme" feature will get removed.

[jeremy447]

That's not a problem :
https://jeremy.bicha.net/2017/08/29/gnome-tweaks-3-25-91/#comment-384

[harry-cpp]

I did mention it because of that, #30031 and this request are different, this can be closed while #30031 should be the one left open.

[MattSturgeon]

Surely GLOBAL Dark Theme being removed has no impact on either issue. You can still set Dark Theme on a per-app basis.

…

On Sun, 10 Sep 2017, 22:31 Harry ***@***.***> wrote: I did mention it because of that, #30031 <#30031> and this request are different, this can be closed while #30031 <#30031> should be the one left open. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11979 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE0BImUD18d3lQ7Rt5eyprnq5IxMW9n1ks5shFUXgaJpZM4J8Gd0> .

[bpasero]

#16363

[jhasse]

Surely GLOBAL Dark Theme being removed has no impact on either issue. You can still set Dark Theme on a per-app basis.

Even a global dark theme is still supported, simply by selecting a dark theme.