Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[folding] File contents scrolls if folding is turned off #3314

Closed
weinand opened this issue Feb 23, 2016 · 2 comments
Closed

[folding] File contents scrolls if folding is turned off #3314

weinand opened this issue Feb 23, 2016 · 2 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verified Verification succeeded
Milestone
Feb 2016

Comments

@weinand
Copy link
Contributor

weinand commented Feb 23, 2016

On testing #2994

  • open the User preferences and prepare for editing "editor.folding"
  • in another VS Code column open a file that uses indentation and scroll to some position
  • remember the line number of the top line
  • collapse any region

Observe: top line doesn't change (which is good)

  • set "editor.folding" to false

Observe: file contents scrolls and the top line changes
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Feb 23, 2016
@aeschli aeschli changed the title File contents scrolls if folding is turned off [folding] File contents scrolls if folding is turned off Feb 24, 2016
@aeschli aeschli added the editor-folding Editor code folding issues label Feb 24, 2016
@aeschli aeschli added this to the Feb 2016 milestone Feb 24, 2016
@aeschli
Copy link
Contributor

aeschli commented Feb 25, 2016

I fixed it by making sure the cursor position stays visible when collapsing a region (instead of making sure the top line is the same)

@aeschli aeschli mentioned this issue Feb 25, 2016
Closed
aeschli added a commit that referenced this issue Feb 25, 2016
@aeschli
Keep (un)folded region revealed (#3314)
e68a6bd
@aeschli aeschli assigned weinand and unassigned aeschli Feb 26, 2016
@aeschli
Copy link
Contributor

aeschli commented Feb 26, 2016

  • when clicking on a fold icon, I make sure that this line stays visible
  • in all other cases we make sure the current cursor line stays visible

@weinand weinand added the verified Verification succeeded label Feb 29, 2016
@rebornix rebornix mentioned this issue Nov 28, 2016
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verified Verification succeeded
Projects
None yet
Milestone
Feb 2016
Development

No branches or pull requests
2 participants
@weinand @aeschli