Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[folding] Add code folding for markdown based on heading level #3347

Closed
Tyriar opened this issue Feb 23, 2016 · 14 comments · Fixed by #44795
Closed

[folding] Add code folding for markdown based on heading level #3347

Tyriar opened this issue Feb 23, 2016 · 14 comments · Fixed by #44795
Assignees
@mjbvz
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality markdown Markdown support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2016 

# Some heading

Collapsing `#` should collapse all lower level headings; `##`, `###`, etc.

## Another heading

Collapsing `##` should collapse all lower level headings; `###`, `####`, etc.

### Another heading

And so on...
@Tyriar Tyriar added the markdown Markdown support issues label Feb 23, 2016
@joaomoreno joaomoreno assigned bpasero and aeschli and unassigned bpasero Feb 24, 2016
@aeschli aeschli added the feature-request Request for new features or functionality label Feb 25, 2016
@aeschli aeschli added this to the Backlog milestone Feb 25, 2016
@aeschli aeschli changed the title Add code folding for markdown based on heading level [folding] Add code folding for markdown based on heading level Feb 25, 2016
@aeschli aeschli added the editor-folding Editor code folding issues label Feb 25, 2016
@aeschli aeschli mentioned this issue Feb 25, 2016
Closed
@bpasero
Copy link
Member

bpasero commented Feb 29, 2016

👍

1 similar comment
@windsource
Copy link

+1

@darkf
Copy link

darkf commented Dec 5, 2016

Why is this essential feature still not a thing?

@Tyriar
Copy link
Member Author

Tyriar commented Dec 5, 2016

@darkf because it relies on #3422 which is non-trivial and it needs to be prioritized against other work.

@sixeyes
Copy link

sixeyes commented Apr 6, 2017

+1

1 similar comment
@gmack00
Copy link

gmack00 commented Jul 21, 2017

+1

@yusiwen
Copy link

yusiwen commented Aug 8, 2017

+1
or adding a heading list view(TOC view) on the right side, it's really convenient for editing a large markdown file.

@mjbvz mjbvz self-assigned this Sep 8, 2017
@iswade
Copy link

iswade commented Oct 12, 2017

Please refer to the org-mode tab feature to implement, it's powerful.

@sejnub
Copy link

sejnub commented Nov 8, 2017

+1

@aeschli
Copy link
Contributor

aeschli commented Nov 22, 2017

duplicate of #3422

@aeschli aeschli closed this as completed Nov 22, 2017
@Kshitiz-Sharma Kshitiz-Sharma mentioned this issue Dec 7, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2018
@mjbvz mjbvz modified the milestones: Backlog, March 2018 Mar 1, 2018
@mjbvz mjbvz reopened this Mar 1, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 1, 2018

Reopening to track the markdown specific work of #3422

@microsoft microsoft unlocked this conversation Mar 1, 2018
mjbvz added a commit to mjbvz/vscode that referenced this issue Mar 1, 2018
@mjbvz
Add markdown header based folding
012a2b7 
Fixes microsoft#3347

Adds folding based on markdown heading level. Headers fold to the next header of <= level
@mjbvz mjbvz mentioned this issue Mar 1, 2018
Merged
mjbvz added a commit that referenced this issue Mar 2, 2018
@mjbvz
Add markdown header based folding (#44795)
99413dc 
Fixes #3347

Adds folding based on markdown heading level. Headers fold to the next header of <= level
@yzhang-gh
Copy link
Contributor

I noticed that this is already implemented in the latest insider build, thanks a lot.
One more request, would you please preserve the last blank line of a folded region?
I mean

- # Heading 1

  Some text

- # Heading 1

  Another text

becomes

+ # Heading 1

+ # Heading 1

instead of

+ # Heading 1
+ # Heading 1

One reason is that currently

- # Heading 1           - # Heading 1

  ...                     ...

- ## Subheading 1  -->  + ## Subheading 1
                        - # Heading 2
  ...

- # Heading 2

@mjbvz mjbvz added the verification-needed Verification of issue is requested label Mar 26, 2018
@sandy081 sandy081 added the verified Verification succeeded label Mar 27, 2018
@hikinthru
Copy link

Can anyone update the status on this?

@Tyriar
Copy link
Member Author

Tyriar commented Apr 2, 2018

@hikinthru it's coming to the next stable release.

@joaompinto joaompinto mentioned this issue Apr 13, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality markdown Markdown support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

Successfully merging a pull request may close this issue.

Add markdown header based folding mjbvz/vscode