Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: terminal font is cut off #34208

Closed
aeschli opened this issue Sep 12, 2017 · 7 comments
Closed

linux: terminal font is cut off #34208

aeschli opened this issue Sep 12, 2017 · 7 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
October 2017

Comments

@aeschli
Copy link
Contributor

aeschli commented Sep 12, 2017

Elementary OS Freya (based on 14.04)
1.70.0-insiders

The terminal font has changed. It seems to be too big for the line height chosen.

image
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Sep 12, 2017
@aeschli aeschli changed the title terminal font is cut off linux: terminal font is cut off Sep 12, 2017
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 12, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 12, 2017

@aeschli do you have a font set in your settings?

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Sep 12, 2017
@aeschli
Copy link
Contributor Author

aeschli commented Sep 13, 2017

@Tyriar No font settings. To verify I just ran code-insiders on a empty user-data-dir.
Not sure if that helps:
image

@Tyriar Tyriar added this to the October 2017 milestone Sep 14, 2017
@jgillich
Copy link

jgillich commented Sep 16, 2017 •
edited
Loading

Similar issue on Fedora 26:

screenshot from 2017-09-16 13-49-56

This only appears in the latest insiders build, not stable. Also no custom font set.

Edit: Fixed by installing google-droid-sans-mono-fonts. If needed, I can check which font was used before.

@Tyriar
Copy link
Member

Tyriar commented Sep 16, 2017

@jgillich if you can figure out what font it was before that would be great. Also what commit was the version you saw this one (in help > about)?

@jgillich
Copy link

@Tyriar The font appears to be Liberation Mono, commit b0c0634.

@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2017

The likely fix here is to allow the drawable area within a terminal grid cell to include the line height of the cell and then increase the line height in settings.

@Tyriar
Copy link
Member

Tyriar commented Oct 18, 2017

Duplicate #35901

@Tyriar Tyriar closed this as completed Oct 18, 2017
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 18, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
3 participants
@jgillich @Tyriar @aeschli