New terminal lines rendering cuts off bottom/top of characters like underscore

[viktorku]

The new terminal rendering cuts off the bottom part of "long" characters, such as g, j and y.

1.17.0:

1.17.1:

• VSCode Version: 1.17.0

Version 1.17.0
Commit be377c0faf7574a59f84940f593a6849f12e4de7
Date 2017-10-04T23:33:45.303Z
Shell 1.7.7
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

• OS Version: Ubuntu Trusty 14.04

Steps to Reproduce:

1. Open the Terminal
2. Start typing git checkout -b feature/object

Reproduces without extensions: Yes

[fpauser]

Same problem here.

[ghost]

similar to #35794 but on fedora it cuts off the top part

[masonj5n]

Chops the top off on Fedora 26.

[imgss]

Same problem here.

[ivcosla]

I just changed the "terminal.integrated.fontFamily" value. My issue was that underscores were not displayed using DejaVu Sans Mono. With other fonts they are displaying, not sure if it would help to fix your problem guys, but sure is worth to give it a try.

[jashworth]

The variable width font that I'm partial to now renders like this.

[Tyriar]

@imgss see #35660
@jashworth see #35681

[Tyriar]

@viktorku what's in your settings.json file?

[viktorku]

In 1.17.1 the rendering changed (it's somewhat blurrier and smaller fontsize - see top comment for comparison) but the bug prevails:

@Tyriar This also happens for a fresh code instance (without settings.json in the project's root .vscode). My User Settings are like this:

{
    "workbench.sideBar.location": "left",
    "files.exclude": {
        "**/.git*": false,
        "**/.svn": true,
        "**/.hg": true,
        "**/.DS_Store": true,
        "**/.tags*": true,
	"**/.pyc": true,
        ".catkin_tools/**/packages": true,
        "build": true,
        "devel": true,
        "logs": true,
        "src/external": true,
        "**/CMakeLists.txt.user": true,
        "**/__pycache__": true
    },

    "editor.fontSize": 12,
    "editor.tabSize": 2,
    "editor.wordWrap": "on",
    "editor.rulers": [
        100
    ],

    "[python]": {
        "editor.tabSize": 4
    },

    "files.trimTrailingWhitespace": true,
    "diffEditor.ignoreTrimWhitespace": false,

    "workbench.editor.enablePreviewFromQuickOpen": false,

    "window.zoomLevel": 0,

    "clang-format.executable": "/usr/bin/clang-format-3.8",
    "clang-format.style": "Google",
    "clang-format.language.javascript.enable": false,

    "prettier.printWidth": 100,
    "prettier.singleQuote": true,
    "prettier.bracketSpacing": true,
    "workbench.colorTheme": "One Dark Pro",

    "editor.multiCursorModifier": "alt",
    "git.ignoreLegacyWarning": true,
    "workbench.startupEditor": "newUntitledFile",

    "eslint.nodePath": "/home/viktor/.nvm/versions/node/v7.4.0/bin/node",

    "python.linting.pylintArgs": [
        "--load-plugins pylint-django"
    ]
}

[mpartipilo]

Similar issue. Image here: #36322 (comment)

[Tyriar]

Using the insiders build I believe you can workaround this currently by setting:

"terminal.integrated.lineHeight": 1.1

[CoenraadS]

@Tyriar

The line height workaround doesn't work for me in latest insiders

Running Ubuntu in virtualbox

• VSCode Version: Code - Insiders 1.18.0-insider (81cca6c, 2017-10-31T06:24:27.011Z)
• OS Version: Linux x64 4.10.0-37-generic

In my screenshot I typed some underscores _________

I also tried crazy heights like 2 but nothing seems to help

This is a regression from 1.17 where it displays fine:

Setting terminal.integrated.fontSize": 13 is a workaround for me

[simon387]

yeah, fixed on fedora26 VSC 1.17.2 Shell 1.7.7 with the terminal.integrated.fontSize option

[DannyMexen]

Ubuntu 17.10 here and terminal.integrated.fontSize solved it. Thanks, everyone.

[kwahab]

Simply setting terminal font to Hack on Kubuntu 18.04 fixed it for me.
"terminal.integrated.fontFamily": "Hack"

[Remzi1993]

When gets this fixed? It's a issue from 2 years ago already!
I don't understand why it's not a priority.

Setting: terminal.integrated.fontSize to 15 fixed the issue.
Maybe, make this font size the default? This could be an option.

[Kryptoxic]

I work a lot in a linux environment compared to windows environment so when changing over from windows, I always get irritated that I cant see the underscores and I see that this has been going on for two years already. Commenting so I can follow this issue to see it fixed.

[ghost]

I'm not using vscode, but I'm seeing this issue on ArchLinux in both Chromium and Hexchat with certain font-sizes only, but not only with DejaVu Sans Mono (Book) but also with Noto Sans Mono but way less visible. Tested for chars: qpjy_. With Noto the underscore is always visible, but other chars can be seen cut off a bit.

Inconsolata(and/or Nimbus Mono PS too) font however seems to exhibit no such issues. Hence why I'm switching my Monospace font to it.

$ fc-match monospace
Inconsolata-Regular.ttf: "Inconsolata" "Regular"

This here is an interesting read as to why this descenders cut off might be happening.
Another interesting comment with some workarounds possibly.

[bprosnitz]

Setting font size to 13.9 (from the default of 14) fixed underscores for me.

[Tyriar]

The current thing blocking this is stabilizing the WebGL renderer, see upstream query: https://github.com/xtermjs/xterm.js/issues?q=is%3Aopen+is%3Aissue+label%3Aarea%2Faddon%2Fwebgl

[suntaoTs]

@Tyriar

The line height workaround doesn't work for me in latest insiders

Running Ubuntu in virtualbox

• VSCode Version: Code - Insiders 1.18.0-insider (81cca6c, 2017-10-31T06:24:27.011Z)
• OS Version: Linux x64 4.10.0-37-generic

In my screenshot I typed some underscores _________

I also tried crazy heights like 2 but nothing seems to help

This is a regression from 1.17 where it displays fine:

Setting terminal.integrated.fontSize": 13 is a workaround for me

fontSize: 13 and fontSize: 15 all can solve this problem. just advise that the default Size not be 14, it will be solved.

[l-miskovsky]

Underscores are finally visible with fontSize: 14 and the latest 1.40 version 🎉

[vinicpac]

@surges
Underscores are finally visible with fontSize: 14 and the latest 1.40 version

Still not working for me on: Ubuntu 18.04.3 LTS x64, VS Code 1.40

I have to use the workaround "terminal.integrated.fontSize": 15" in order to see the underscore.

[Bessonov]

@viniciussp4 I use my docker image with ubuntu 18.04 for development and I see the underscores:
https://github.com/Bessonov/dev-image

Can you check your installation and vscode settings or the image?
https://github.com/Bessonov/dev-image/blob/master/Dockerfile#L28

I mean, if it's working in a reproducible way with docker, then it could be a local problem.

[nobi1007]

@Tyriar

The line height workaround doesn't work for me in latest insiders

Running Ubuntu in virtualbox

• VSCode Version: Code - Insiders 1.18.0-insider (81cca6c, 2017-10-31T06:24:27.011Z)
• OS Version: Linux x64 4.10.0-37-generic

In my screenshot I typed some underscores _________

I also tried crazy heights like 2 but nothing seems to help

This is a regression from 1.17 where it displays fine:

Setting terminal.integrated.fontSize": 13 is a workaround for me

I don't get it but only the with font-size of 14 there comes the problem, but with other font sizes it not the case. Any reason ??

[segevfiner]

It's an off by one error in measuring the "height" of the font that doesn't happen in all font sizes in the canvas renderer of xterm.js. If there is someway to fix up this computation then that would fix this for the canvas renderer. I think there was an issue in xterm.js where I explained my investigation of this.

[Tyriar]

The issue is that rows are clipped so that we can render rows independently, otherwise the whole terminal would need an update. #84440 fixes this and makes the terminal way faster so stay tuned 😃

[hems]

I'm running OSX and I used to have "ProggyCleanTTSZ" ( from the amazing https://proggyfonts.net/ ) and it worked like a charm.

One day i decided to accept the "Update" on VS Code and that terrible update started cropping my text on the terminal.

I played with all settings possible here in this thread and nothing worked other than changing my font to "monospace", which is less than ideal as i'm used to use ProggyClean for over 15 years now 😢

I hope this get fixed before i move back to vim, which perhaps i should never have left, lol

[Tyriar]

@hems that's a bug in Chromium that shows up on some fonts #84432, https://bugs.chromium.org/p/chromium/issues/detail?id=1026254

[hems]

@hems that's a bug in Chromium that shows up on some fonts #84432, https://bugs.chromium.org/p/chromium/issues/detail?id=1026254

hopefully fixed soon

[Tyriar]

You can try out the new WebGL-based renderer where this issue is fixed by using this:

"terminal.integrated.rendererType": "experimentalWebgl"

It's available in Insiders and in the upcoming version.

The canvas renderer will eventually be removed as the webgl one is basically a highly optimized/low-level version of it.

[hems]

"terminal.integrated.rendererType": "experimentalWebgl"

that just gave me new problems, like my text is rendered out of the Terminal box sometimes and i can't see it. but if i type for instance ls -la then i can se the result because it spans many lines.

[Tyriar]

@hems I haven't heard of a problem like that before, please report in a new issues with repro steps.

[Tyriar]

If you're still on the canvas renderer, @hems calls out a workaround in #107942 (comment) to regenerate the font file:

After months and months having the issue with my font being cropped on the bottom of the terminal i managed to solve the issue by importing the font into https://www.glyphrstudio.com/online/ then export it as OTF.