Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proportional fonts are rendered as fixed width fonts in the terminal #35681

Closed
mmzeeman opened this issue Oct 6, 2017 · 18 comments
Closed

Proportional fonts are rendered as fixed width fonts in the terminal #35681

mmzeeman opened this issue Oct 6, 2017 · 18 comments
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code terminal General terminal issues that don't fall under another label
Milestone

Comments

@mmzeeman
Copy link

mmzeeman commented Oct 6, 2017

  • VSCode Version: 1.17.0
  • OS Version: macOS 10.12.6

Steps to Reproduce:

  1. Select a proportional font. (I use https://blog.golang.org/go-fonts)
  2. Open the terminal and do something. Text is rendered as if the font is a fixed width font.

screen shot 2017-10-06 at 08 23 37

Reproduces without extensions: Yes/No

@vscodebot vscodebot bot added the new release label Oct 6, 2017
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Oct 6, 2017
@Tyriar Tyriar added the feature-request Request for new features or functionality label Oct 6, 2017
@Tyriar Tyriar added this to the Backlog milestone Oct 6, 2017
@CruCo
Copy link

CruCo commented Oct 6, 2017

I've the same results on Win 10 Pro x64 / VSCode 1.17.0 while using a custom "editor.fontFamily"-setting.
grafik

By using the standard font family the problem is gone
grafik
grafik

@mmzeeman
Copy link
Author

mmzeeman commented Oct 6, 2017

I found out that it is possible to use a different font in the terminal. Currently I have this setting:

{
    "editor.fontFamily": "Go",
    "terminal.integrated.fontFamily": "Go Mono",
    \\

So it is possible to use a proportional font in the editor and a fixed width one in the editor

Things look ok now.

screenshot from 2017-10-06 12-09-27

@nickserv
Copy link

Proportional fonts are just as valid as monospace fonts for coding. It would be nice to have better rendering in the terminal since the extra spacing makes proportional fonts difficult to read (they seem to have even wider spacing than monospace fonts). For now I'm setting terminal.integrated.fontFamily to a monospace font similarly to @mmzeeman's tip.

@Gaolz
Copy link

Gaolz commented Dec 5, 2017

Update settings to "terminal.integrated.fontFamily": "Monaco", it works for me.

@Hideer
Copy link

Hideer commented Feb 7, 2018

Resetting the font does not solve the problem.

@mmzeeman
Copy link
Author

mmzeeman commented Feb 7, 2018

You are right. It is a workaround, you have to use a monospaced font in the terminal.

@Hideer
Copy link

Hideer commented Mar 8, 2018

I set the terminal font for "terminal. Integrated. FontFamily" is still doesn't work, so that the terminal can make me look very pain

@Tyriar
Copy link
Member

Tyriar commented Mar 8, 2018

@Hideer you need to use a monospace font, variable width fonts are not supported within the terminal.

@mattpilott
Copy link

Hey, I'm in need of this "terminal.integrated.letterSpacing": 0.25, when will something like this be added, or is there a way I can achieve this currently?

@Tyriar
Copy link
Member

Tyriar commented May 4, 2018

@matt3224 decimal letter spacing would only be added after proportional font support is added. Font rendering is currently done on a canvas and every character is drawn on a grid and their texture cached to boost performance, because of this their x,y coordinates need to be integers (otherwise they would be blurry).

@mattpilott
Copy link

@Tyriar how far along is the proportional font support?

@Tyriar
Copy link
Member

Tyriar commented May 5, 2018

@matt3224 it's not planned

@rfgamaral
Copy link

@Tyriar But you closed #35695 in favor of this one and now it's not planned? As far as I can see on xtermjs/xterm.js#1044, letter spacing is supported by xterm, right? So could we at least get that on VS Code?

I mean, I just wanted to have 1px more between each character because right now they just feel weird. And that 1px between each character would render the terminal much more closely to how Windows Command Prompt renders. It's just 1px, it's an integer and their texture could still be cached without a performance hit, right?

@Tyriar
Copy link
Member

Tyriar commented May 9, 2018

@rfgamaral it was actually an oversight that I didn't bring in letterSpacing as a setting in vscode, this comment is wrong #35695 (comment), I must have missed it.

I'll add this in the May release as that's trivial. Tracking in #49566 to make sure it gets done/verified. Sorry about the hassle and thanks for calling this out.

@Tyriar Tyriar closed this as completed May 9, 2018
@Tyriar Tyriar reopened this May 9, 2018
@rfgamaral
Copy link

@Tyriar No problem, thank you :)

@dulara1994
Copy link

I had the same issue. because I imported settings from someone else. (I'm using linux, imported settings from a mac)
Go to Settings > filter settings to show modified settings >> there i deleted everything in front of the font field. restart the IDE.
if you import settings using a service such as Settings Sync. It may be because you are trying to use a font that is not currently installed on your computer.
also a reminder usually terminals, code editors are only support mono-space fonts.

screenshot from 2018-10-05 20-28-00

@Tyriar
Copy link
Member

Tyriar commented Oct 5, 2018

@dulara1994 remember you can also use font fallbacks, so you can have fonta, fontb, monospace as your font config if the fonts aren't on all your OS's.

@Tyriar
Copy link
Member

Tyriar commented Oct 8, 2019

Closing as font fix, you should be using a monospace font in a terminal. If you're experiencing this issue you can fix it by configuring the terminal.integrated.fontFamily setting to use a monospace font.

@Tyriar Tyriar closed this as completed Oct 8, 2019
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Oct 8, 2019
@microsoft microsoft locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

10 participants