Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImportFileAction doesn't use URI #34235

Closed
jrieken opened this issue Sep 12, 2017 · 1 comment
Closed

ImportFileAction doesn't use URI #34235

jrieken opened this issue Sep 12, 2017 · 1 comment
Assignees
@bpasero @isidorn
Labels
debt Code quality issues remote Remote system operations issues
Milestone
September 2017

Comments

@jrieken
Copy link
Member

jrieken commented Sep 12, 2017

re #34218

Most file actions work on URI and to make them work with uris from other schemes little work is needed, however it seems that the import action and the drag&drop model work with paths:
https://github.com/Microsoft/vscode/blob/joh/ftp/src/vs/workbench/parts/files/browser/fileActions.ts#L852
@jrieken jrieken added the remote Remote system operations issues label Sep 12, 2017
@bpasero bpasero added this to the September 2017 milestone Sep 12, 2017
@bpasero bpasero added the debt Code quality issues label Sep 12, 2017
@bpasero
Copy link
Member

bpasero commented Sep 13, 2017

@jrieken I hope I did the right thing in 47cfc8b#diff-9404b1da682862c61dce10b84ff76e5cR850

bpasero added a commit that referenced this issue Sep 14, 2017
@bpasero
ImportFileAction doesn't use URI (fixes #34235)
6c9aa9a
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@isidorn isidorn

Labels
debt Code quality issues remote Remote system operations issues
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@bpasero @jrieken @isidorn