Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an API to resolve a ThemeColor into its real color #34411

Closed
eamodio opened this issue Sep 14, 2017 · 4 comments
Closed

Provide an API to resolve a ThemeColor into its real color #34411

eamodio opened this issue Sep 14, 2017 · 4 comments
Assignees
Labels

Comments

@eamodio
Copy link
Contributor

eamodio commented Sep 14, 2017

AFAIK, there isn't any way to resolve a ThemeColor into its real css value. This would probably be useful in quite a few scenarios, but here's what I'm trying to do.

In the image below, I am adding an icon in the top right (link icon) to the hover, but because I have no controls for light vs dark, it is hard to get it to be visible.

image

What I'd like to do is actually use one of the theme colors (aside -- even though it is an svg I couldn't get any css color inheritance to work, neither as a file nor data-uri). So if there was a way to get the real color for a ThemeColor, I could build an svg document with the proper color and embed it into a data-uri.

@aeschli
Copy link
Contributor

aeschli commented Sep 15, 2017

duplicate of #32813

As described, I'm trying to avoid adding such API, as it involves sending theme change events and requiring clients to handle theme color changes. Maybe not such an issue with the hover.

For now, instead of using an image, any chance you can this with a font character?

@aeschli aeschli closed this as completed Sep 15, 2017
@eamodio
Copy link
Contributor Author

eamodio commented Sep 15, 2017

@aeschli do we have access to the octicons in the hovers?

@aeschli
Copy link
Contributor

aeschli commented Sep 18, 2017

@jrieken Can you reply to #34411 (comment)?

@eamodio
Copy link
Contributor Author

eamodio commented Sep 18, 2017

@aeschli As far as I can tell we don't, I ended up using a unicode character, but it would be nice to support both real icons and/or octicons.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants