Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: New RelativePattern support in extension APIs #34831

Closed
3 tasks done
bpasero opened this issue Sep 22, 2017 · 1 comment
Closed
3 tasks done

Test: New RelativePattern support in extension APIs #34831

bpasero opened this issue Sep 22, 2017 · 1 comment

Comments

@bpasero
Copy link
Member

bpasero commented Sep 22, 2017

Refs: #34157

Complexity: 3

We have 3 places where we ask for a file glob pattern:

  • workspace.createFileSystemWatcher
  • workspace.findFiles(include, exclude))
  • DocumentFilter#pattern

To make it easier to scope a pattern to a WorkspaceFolder, we introduced RelativePattern which allows to specify a base and a pattern to match against. Only file paths that are within that base file path are considered a match for the pattern.

Verify:

  • the documentation around the 3 APIs mentioned above makes sense and is helpful
  • you can use the 3 APIs from your extension and they work with either string or RelativePattern as documented.

FYI - to test against the latest API do the following:

open your extensions package.json file
change the engine.vscode property to *
run npm run postinstall (assuming you have the vscode module as dev-dependency)
undo the engine-version change from step 2

@bpasero
Copy link
Member Author

bpasero commented Sep 27, 2017

@mjbvz fyi due to my change in #35103 the order of ctor arguments has changed. This shouldn't be a problem if you test on todays insider where the change is in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants