Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to change RelativePattern ctor argument order #35103

Closed
jrieken opened this issue Sep 26, 2017 · 0 comments
Closed

Consider to change RelativePattern ctor argument order #35103

jrieken opened this issue Sep 26, 2017 · 0 comments
Assignees
Labels
api under-discussion Issue is under discussion for relevance, priority, approach

Comments

@jrieken
Copy link
Member

jrieken commented Sep 26, 2017

re #34831

Maybe it's me but it feels weird to have a relative pattern that puts the pattern before the base. While the reading goes "pattern 'relative to' base", the mental model goes like "base + pattern"

new vscode.RelativePattern('*.ts', folder);

vs

// closer to how I would manually write a pattern
new vscode.RelativePattern(folder, '*.ts');
@jrieken jrieken added api under-discussion Issue is under discussion for relevance, priority, approach labels Sep 26, 2017
@bpasero bpasero added this to the September 2017 milestone Sep 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants