Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal canvas renderer #34868

Closed
3 tasks done
Tyriar opened this issue Sep 23, 2017 · 1 comment
Closed
3 tasks done

Terminal canvas renderer #34868

Tyriar opened this issue Sep 23, 2017 · 1 comment

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 23, 2017

#34169

Complexity: 4

All rendering done by the terminal has moved from a completely DOM-based model to using canvas instead. Here are some things to focus on and look out for:

  • Unicode characters, emojis, etc. behave correctly
    -,Tweaking the terminal settings, font size/family and line height in particular
  • Blurry text, lack of sub-pixel anti-aliasing
  • The rows/columns not being the correct size for the panel
  • Rows being cut off on the top
  • Mouse coordinates when using selection, links and xterm mouse events are accurate
  • Changing the window zoom level works as expected
@alexdima
Copy link
Member

Nice job!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants