Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection in the terminal does not reflect mouse position #35114

Closed
alexdima opened this issue Sep 26, 2017 · 10 comments
Closed

Selection in the terminal does not reflect mouse position #35114

alexdima opened this issue Sep 26, 2017 · 10 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
October 2017

Comments

@alexdima
Copy link
Member

alexdima commented Sep 26, 2017 •
edited
Loading

Testing #34868

emoji-test.txt

  • save this file as UTF8 with bom (I think it is already)
  • configure "terminal.integrated.scrollback": 5000
  • run chcp 65001
  • run cat emoji-test.txt
  • scroll to British Virgin Islands
  • try to select with the mouse:

mouse-position
@alexdima alexdima added the terminal Integrated terminal issues label Sep 26, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 26, 2017

@alexandrudima you were testing the latest unsigned Insiders correct? I thought I fixed this issue a few days ago.

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Sep 26, 2017
@roblourens roblourens mentioned this issue Sep 26, 2017
Closed
@alexdima
Copy link
Member Author

Yes @Tyriar . Did you attempt to reproduce with the steps I have provided ?

@Tyriar Tyriar added this to the September 2017 milestone Sep 27, 2017
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Sep 27, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 28, 2017
@Tyriar
Calculate mouse coordinates using correct char dimensions
a817439 
Previously the Mouse class was using raw CSS pixels, we need CSS pixels based
on the amount of space the cells take up on the canvas

See microsoft/vscode#35114
@Tyriar Tyriar closed this as completed in 29c6578 Sep 28, 2017
@dbaeumer
Copy link
Member

Reopening. There is still something funny. Following the steps provided by @alexandrudima I can't select from right to left trying to start with the s of British Virgin Islands.

And there is more if I select British Virgin Islands from left to right and the copy it and past it it is missing ds at the end.

@dbaeumer dbaeumer reopened this Sep 29, 2017
@dbaeumer dbaeumer added the verification-found Issue verification failed label Sep 29, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 29, 2017

@dbaeumer I can't repro not being able to select starting at the s, but I can see the copy paste issue. Working on it now.

@Tyriar
Copy link
Member

Tyriar commented Sep 29, 2017

Fun fact: Terminal.app has some similar bugs, this selection will only copy the flag and the reflow is off for emojis with several code points like this.

screen shot 2017-09-29 at 2 54 03 pm

@Tyriar
Copy link
Member

Tyriar commented Oct 1, 2017 •
edited
Loading

Pushing this to October, I have a fix for the emoji-related problems but it's quite large. Since it only affects characters after an emoji on a line it shouldn't be hit too often.

@Tyriar Tyriar modified the milestones: September 2017, October 2017 Oct 1, 2017
@Tyriar
Copy link
Member

Tyriar commented Oct 1, 2017

xtermjs/xterm.js#1017

@Tyriar Tyriar removed the verification-found Issue verification failed label Oct 2, 2017
@Tyriar Tyriar closed this as completed in 4a42b45 Oct 2, 2017
@roblourens
Copy link
Member

Should the flags be shown in the terminal? They are shown in the editor. The other emoji symbols further up in the file are visible.

@roblourens roblourens mentioned this issue Nov 1, 2017
Closed
@roblourens roblourens added the verified Verification succeeded label Nov 1, 2017
@roblourens
Copy link
Member

Mouse selection works, but I filed #37440

@Tyriar
Copy link
Member

Tyriar commented Nov 2, 2017

@roblourens many emojis won't show up the same, this is as designed due to the how the terminal splits some emojis into separate characters/cells

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
4 participants
@roblourens @dbaeumer @Tyriar @alexdima