Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to switch to folder/workspace without window reload #35109

Open
isidorn opened this issue Sep 26, 2017 · 5 comments
Open

Allow to switch to folder/workspace without window reload #35109

isidorn opened this issue Sep 26, 2017 · 5 comments
Labels
feature-request Request for new features or functionality keep Issues we should not close as out of scope workbench-state UI state across restarts
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 26, 2017

#34774

  1. VSCode, open a no folder vscode
  2. Click on the big open folder button in the explorer
  3. Notice that VSCode reloads - unlike most other scenarios where we are adding aditional folders where this just happens
@bpasero
Copy link
Member

bpasero commented Sep 26, 2017

This scenario is blocked by not being able to start/stop extensions without window reload. The folder to open could have specific extension settings configured.

@sandy081
Copy link
Member

sandy081 commented Sep 26, 2017

We have two blockers for this

If we tackle the UI state issue we are good to go for 90 percent of cases. Having different extensions per workspace is less likely. We can trigger reload in only such cases.

@sandy081 sandy081 added the feature-request Request for new features or functionality label Sep 26, 2017
@sandy081 sandy081 added this to the Backlog milestone Sep 26, 2017
@bpasero bpasero added extensions Issues concerning extensions workbench-state UI state across restarts and removed workbench labels Nov 17, 2017
@bpasero bpasero self-assigned this Mar 27, 2018
@bpasero bpasero modified the milestones: Backlog, On Deck Mar 27, 2018
@bpasero bpasero changed the title No folder workspace -> open folder still reloads the workbench Allow to open folder/workspace without window reload Mar 27, 2018
@bpasero bpasero changed the title Allow to open folder/workspace without window reload Allow to switch to folder/workspace without window reload Mar 27, 2018
@bpasero bpasero removed this from the On Deck milestone Jun 26, 2018
@bpasero bpasero added this to the On Deck milestone Sep 30, 2019
@bpasero bpasero modified the milestones: On Deck, Backlog Oct 21, 2020
@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label Nov 3, 2020
@bpasero bpasero closed this as completed Nov 3, 2020
@bpasero bpasero removed *out-of-scope Posted issue is not in scope of VS Code extensions Issues concerning extensions labels Apr 12, 2021
@bpasero bpasero reopened this Apr 12, 2021
@bpasero
Copy link
Member

bpasero commented Apr 12, 2021

Backlog:

  • understand the consequences of entering an existing workspace without reload (memory, processes, singlestons, etc.)
    • limit this only to transitions from an empty workspace into a workspace?
  • restore workspace associated state (e.g. the opened editors)
  • restore backups

@sandy081
Copy link
Member

With individual APIs to stop & start extension hosts, we can now restart extension host with new set of extensions ie., those which are enabled for the folder that is getting opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality keep Issues we should not close as out of scope workbench-state UI state across restarts
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @isidorn @sandy081 and others