Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: transition into multi-root workspace without window reload #34774

Closed
3 tasks done
bpasero opened this issue Sep 21, 2017 · 2 comments
Closed
3 tasks done

Test: transition into multi-root workspace without window reload #34774

bpasero opened this issue Sep 21, 2017 · 2 comments

Comments

@bpasero
Copy link
Member

bpasero commented Sep 21, 2017

Refs: #32945

Complexity: 4

We no longer require a window reload when entering a workspace.

Verify for the following actions:

  • Empty window: Add folders...
  • Empty window: Save workspace as...
  • 1-folder window: Add folders...
  • 1-folder window: Save workspace as...
  • Workspace window: Save workspace as...

That:

  • our UI updates accordingly (e.g. explorer, window title)
  • our migration of UI state (local storage) and hot-exit backups works properly
    • no data-loss: your dirty files are kept and restored when you now do a restart and new dirty files that you create after the transition are also restored properly
    • your UI state is kept and restored when you now restart the instance
  • any window-workspace settings are migrated over to the workspace file (only when transitioning from a 1-folder window)
  • extensions work properly still (we do restart the extension host!)
@bpasero bpasero added this to the September 2017 milestone Sep 21, 2017
@bpasero bpasero changed the title Test: transition into workspace without window reload Test: transition into multi-root workspace without window reload Sep 21, 2017
@bpasero
Copy link
Member Author

bpasero commented Sep 21, 2017

/cc @sandy081

@isidorn
Copy link
Contributor

isidorn commented Sep 26, 2017

Works well 👍

@isidorn isidorn removed their assignment Sep 26, 2017
@weinand weinand removed their assignment Sep 26, 2017
@gregvanl gregvanl assigned gregvanl and unassigned kieferrm and gregvanl Sep 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants