Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi root: transition without window reload #32945

Closed
7 tasks
bpasero opened this issue Aug 22, 2017 · 4 comments
Closed
7 tasks

Multi root: transition without window reload #32945

bpasero opened this issue Aug 22, 2017 · 4 comments
Assignees
Labels
debt Code quality issues feature-request Request for new features or functionality on-testplan plan-item VS Code - planned item for upcoming workbench-multiroot Multi-root (multiple folders) issues

Comments

@bpasero
Copy link
Member

bpasero commented Aug 22, 2017

Now that we can restart the extension host we should explore to enter multi-root workspace mode from 0 or 1 folder workspace without requiring a window reload.

This requires all users of the IWorkspaceContextService to be ready for the transition of zero or one folder into a workspace without window reload. The following larger components need to be adopted:

Instead of statically checking for a workspace being present or not, these components should subscribe to the onDidChangeWorkspaceRoots event and handle all cases (0 folders, 1 folder, N folders).

@vscodebot vscodebot bot added the workbench label Aug 22, 2017
@bpasero bpasero self-assigned this Aug 22, 2017
@bpasero bpasero added debt Code quality issues feature-request Request for new features or functionality workbench-multiroot Multi-root (multiple folders) issues plan-item VS Code - planned item for upcoming labels Aug 22, 2017
@bpasero bpasero added this to the August 2017 milestone Aug 22, 2017
@bpasero
Copy link
Member Author

bpasero commented Aug 23, 2017

I did an initial investigation using the following query in fulltext search (regex, case sensitive, word) to find all clients of the workspace API:
hasWorkspace|hasFolderWorkspace|hasMultiFolderWorkspace|getLegacyWorkspace|getWorkspace

There are some larger components that need to be fit for the transition of "0 folder to workspace" as well as "1 folder to workspace". In general I would say that the transition from 1 folder to a workspace is already covered quite well, but the transition from no folder to a workspace is not covered yet.

I will update the summary of this issue with the components that need to adopt the transition.

@dbaeumer
Copy link
Member

@bpasero I will fold this with making tasks multi workspace capable which is planned for September.

@bpasero
Copy link
Member Author

bpasero commented Aug 24, 2017

@dbaeumer awesome 👍

@bpasero bpasero modified the milestones: September 2017, August 2017 Aug 24, 2017
@bpasero bpasero changed the title Multi root: investigate transition without window reload Multi root: transition without window reload Aug 24, 2017
@bpasero
Copy link
Member Author

bpasero commented Sep 19, 2017

This landed in todays insider release.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues feature-request Request for new features or functionality on-testplan plan-item VS Code - planned item for upcoming workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

5 participants