-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi root: transition without window reload #32945
Comments
I did an initial investigation using the following query in fulltext search (regex, case sensitive, word) to find all clients of the workspace API: There are some larger components that need to be fit for the transition of "0 folder to workspace" as well as "1 folder to workspace". In general I would say that the transition from 1 folder to a workspace is already covered quite well, but the transition from no folder to a workspace is not covered yet. I will update the summary of this issue with the components that need to adopt the transition. |
@bpasero I will fold this with making tasks multi workspace capable which is planned for September. |
@dbaeumer awesome 👍 |
This landed in todays insider release. |
Now that we can restart the extension host we should explore to enter multi-root workspace mode from 0 or 1 folder workspace without requiring a window reload.
This requires all users of the
IWorkspaceContextService
to be ready for the transition of zero or one folder into a workspace without window reload. The following larger components need to be adopted:Instead of statically checking for a workspace being present or not, these components should subscribe to the
onDidChangeWorkspaceRoots
event and handle all cases (0 folders, 1 folder, N folders).The text was updated successfully, but these errors were encountered: