Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trashcan button kills entire terminal process tree including non-console apps #35492

Closed
the-ress opened this issue Oct 2, 2017 · 4 comments
Closed

Trashcan button kills entire terminal process tree including non-console apps #35492

the-ress opened this issue Oct 2, 2017 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded windows VS Code on Windows issues
Milestone
October 2017

Comments

@the-ress
Copy link
Contributor

the-ress commented Oct 2, 2017

  • VSCode Version: Code - Insiders 1.17.0-insider (7ac1f1e, 2017-09-30T05:06:21.234Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions: none

Steps to Reproduce:

  1. Open a non-console app from vscode terminal (e.g. notepad)
  2. Kill the terminal using the trashcan button

Expected: Only the terminal process and any other processes attached to the console should be killed.
Actual: Entire process tree is killed, even non-console applications.
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Oct 2, 2017
@Tyriar
Copy link
Member

Tyriar commented Oct 2, 2017

Yeah I introduced this earlier when trying to fix the process leak problem. Windows terminal support is my big focus in October so it should get resolved there 😃

@Tyriar Tyriar added this to the October 2017 milestone Oct 2, 2017
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug windows VS Code on Windows issues labels Oct 2, 2017
@Tyriar
Copy link
Member

Tyriar commented Oct 2, 2017

Related #26807

@Tyriar Tyriar mentioned this issue Oct 2, 2017
Closed
6 tasks
@Tyriar Tyriar closed this as completed in 5450fbe Oct 3, 2017
@the-ress
Copy link
Contributor Author

the-ress commented Oct 3, 2017

Thanks! This has been keeping me at 1.14. (The fix will ship with 1.18, right?)

@Tyriar
Copy link
Member

Tyriar commented Oct 4, 2017

1.14 o.0 you're missing a lot of good stuff.

Yes the fix is coming in 1.18 in early November.

@roblourens roblourens added the verified Verification succeeded label Nov 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
3 participants
@roblourens @the-ress @Tyriar