Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows support in integrated terminal October 2017 #35505

Closed
3 of 6 tasks
Tyriar opened this issue Oct 2, 2017 · 8 comments
Closed
3 of 6 tasks

Improve Windows support in integrated terminal October 2017 #35505

Tyriar opened this issue Oct 2, 2017 · 8 comments
Assignees
Labels
plan-item VS Code - planned item for upcoming terminal Integrated terminal issues windows VS Code on Windows issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 2, 2017

This is a plan item for terminal work in the October iteration, in rough order of priority:

@Tyriar Tyriar added terminal Integrated terminal issues plan-item VS Code - planned item for upcoming windows VS Code on Windows issues labels Oct 2, 2017
@Tyriar Tyriar added this to the October 2017 milestone Oct 2, 2017
@Tyriar Tyriar self-assigned this Oct 2, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Oct 2, 2017

/cc @dbaeumer

@equinusocio
Copy link

@Tyriar what about this one?
#35963

@Tyriar
Copy link
Member Author

Tyriar commented Oct 11, 2017

@equinusocio that one's not Windows. I suspect that process may be detaching itself or something as there haven't been any reports of it happening on macOS or Linux.

@dbaeumer
Copy link
Member

@Tyriar could we add #33584 to the list. I have requests to better handle spaces in commands and for bash I propose to use \ as a space escape character. Would be cool if I could propose the backtick for PowerShell. This has the advantage of not dealing with quotes which always complicates things.

@Tyriar
Copy link
Member Author

Tyriar commented Oct 12, 2017

@dbaeumer sure I'll see if I can get to it for October. Could you provide repro steps in that issue where you expect it to work, either as a task.json or terminal.integrated.shellArgs.windows?

@ghiscoding
Copy link

@Tyriar what about this one?
#30638
I find it a bit annoying that a cls doesn't clear the history entirely as it comes back in some situations and it seems to be Windows only.

@dbaeumer
Copy link
Member

@Tyriar regarding #33584: I retested this and it seems to work using this task now in a workspace that has a test folder directory. The task is:

		{
			"type": "shell",
			"taskName": "dir",
			"command": "dir test` folder"
		}

Terminal must be PowerShell. The internal launch args are:

capture

@eamodio
Copy link
Contributor

eamodio commented Oct 26, 2017

@Tyriar maybe #36989 can be included here too?

@Tyriar Tyriar closed this as completed Oct 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plan-item VS Code - planned item for upcoming terminal Integrated terminal issues windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

5 participants