Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test git status in explorer #37159

Closed
2 tasks done
jrieken opened this issue Oct 30, 2017 · 1 comment
Closed
2 tasks done

Test git status in explorer #37159

jrieken opened this issue Oct 30, 2017 · 1 comment

Comments

@jrieken
Copy link
Member

jrieken commented Oct 30, 2017

Test for: #178

Complexity: 3

We have added git color clues to the explorer. Please test this:

  • Check that you see GIT colors and badges for modified, untracked, and ignored files
  • Test that you can turn on/off colors and badges via explorer.decorations.colors and explorer.decorations.badges.
  • Check that those setting-names make sense and that they have good doc
  • Test that you can configure the colors in themes or settings via git.XYZForeground-settings.
  • Check that those color-names make sense
  • Test that the colors work well with our default themes
  • Check that label/badges update nicely and that no stale information is shown
  • Test that the SCM viewlet shows correct information, test that it shows resources properly that show in two buckets (staged & changed)
@jrieken jrieken added this to the October 2017 milestone Oct 30, 2017
@NgxDev
Copy link

NgxDev commented Oct 31, 2017

I'm still having problems with ignored color. It refuses to apply it.
Just tried setting some lime/bright green so it would be obvious, I thought maybe it's there and I'm not seeing it. But it's not.

Also, notice the "A" badges. Shouldn't those only appear on "Added" files? Right now, they also appear for "Untracked" files.

image

@joaomoreno joaomoreno assigned joaomoreno and unassigned auchenberg Oct 31, 2017
@joaomoreno joaomoreno removed their assignment Oct 31, 2017
@mjbvz mjbvz removed their assignment Oct 31, 2017
@mjbvz mjbvz closed this as completed Oct 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants