Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems decoration settings is poorly named #37299

Closed
joaomoreno opened this issue Oct 31, 2017 · 2 comments
Closed

Problems decoration settings is poorly named #37299

joaomoreno opened this issue Oct 31, 2017 · 2 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug file-decorations verified Verification succeeded
Milestone
October 2017

Comments

@joaomoreno
Copy link
Member

Testing #37159

Currently there is:

  • explorer.decorations.colors
  • explorer.decorations.badges
  • problems.decorations.enabled

The last one is oddly named, since it applies to the explorer as well.
@jrieken jrieken added file-decorations under-discussion Issue is under discussion for relevance, priority, approach labels Oct 31, 2017
@jrieken
Copy link
Member

jrieken commented Oct 31, 2017

Yeah, what's missing is the equivalent setting in the git land. Generally there is two concepts: (1) configure the providers such as git and problems and (2) configure the consumers such as the explorer. The first two settings are consumer-settings and the only once because we current don't show decorations anywhere else. The latter, which we didn't announce btw, is a provider setting. We might need git.decoration.enabled for completeness and to make this more well-rounded...

@jrieken jrieken added this to the October 2017 milestone Oct 31, 2017
jrieken added a commit that referenced this issue Nov 1, 2017
@jrieken
add git.decorations.enabled setting, #37299
5efffdf
jrieken added a commit that referenced this issue Nov 1, 2017
@jrieken
also control icon appearance with git.decorations.enabled setting, #…
bab6929 
…37299
@jrieken jrieken closed this as completed Nov 1, 2017
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Nov 1, 2017
@jrieken
Copy link
Member

jrieken commented Nov 1, 2017

Verify that there is a setting git.decorations.enabled that controls if git feeds file decorations into the system or not.

@weinand weinand added the verified Verification succeeded label Nov 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug file-decorations verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @weinand