Consider not having a singleton debugConsole

[jrieken]

re #37167

Would it make sense to have the console on the DebugSession-type? It would still print to the (implementation-singleton) console but will allow us to have multiple consoles in the future (when multiple debug sessions are active). Something like this

export interface DebugSession {
  //...

  console: DebugConsole
}

[weinand]

Yep, I thought the same when starting to work on this API.

But then I noticed that the lifecycle of a DebugSession is the same as that of a debug adapter
which makes it impossible to output to the debug console before the debug adapter has started (and that is actually the main use case).

[weinand]

I do not see an alternative to introducing the debug console singleton.
Closing.

[jrieken]

It is dangerous tho

[weinand]

Would it be better to use an activeDebugConsole instead?

[jrieken]

Maybe... It at least signals that there can be (in the future) many and that they can change... If you ever want to support showing multiple debug consoles (which I think isn't a crazy request given that I can launch many debuggers at once) in parallel then the API shouldn't be in your way

[weinand]

Renamed vscode.debug.console to vscode.debug.activeDebugConsole.
There is no change event yet and the value of activeDebugConsole can never be undefined (to make the API not a pita to use).