-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 3 way merge for git conflicts #37350
Comments
This will be a super cool feature, I use |
Any news on this? this feature would be amazing. On one hand, there is a diff tool (i.e. comparing two files) in VS code, but you cannot edit / chose what to keep; on the other hand, there is a merge conflict tool that allows to chose what to keep (current change / their change). Now, the best would be to have both tools into one tool, such as the tool suggested by @uyhung. I also wanted to add, for any contributor who comes by: VS Code is an amazing piece of software, keep it up :) ! |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Anyone know if there is any plugin that can make this possible ? |
@rajjejosefsson As I said above, you can set: ( [merge]
conflictStyle = diff3 to see them/common/us. It won't change the VSCode formatting/theme, but you will get those three parts to your diff instead of just them/us as is the (git) default. Unless there's something else (other than opening multiple dialogues just to get back to view a diff in the file you already had open) that JetBrains IDEs offer that I'm missing here? |
The newly released Sublime Merge has a similar implementation. |
You can add these configuration in your .gitconfig file and type "git mergetool" on your terminal whenever conflict appears. It'll only open your merge gui interface from webstorm for each file.
|
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
@daviddossett @isidorn what is the status of 3 way merge because, in the iteration plan, you are working 3-way merge. |
We are working on 3-way merge - we are in the investigation phase. As soon as we have updates we will share here. We hope this is something that will happen this year. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Hassling contributors for ETAs isn't going to get it released faster. Please be appreciative that someone has taken the time to put their efforts into making this happen for us all. |
Hi @isidorn, my guess is most of the people here expect a 3-way merge screen with a magic wand like Intellij had. Please consider having such that feature too. |
Just repeating what @isidorn said before: work has started and you can expect something "real" soon'ish, likely May. I have locked this issue because unfortunately unhelpful comments out-weight helpful ones. We have an idea what to do and everyone is invited to provide constructive feedback as soon as this land in insiders. We will be using this feature area label: merge-editor Thanks for being patient and stay tuned. |
* introduce `--merge` to bring up merge editor (for #5770) * wait on proper editor when merging * sqlite slowness * disable flush on write in tests unless disk tests * more runWithFakedTimers * disable flush also in pfs * introduce `IResourceMergeEditorInput` * cleanup * align with merge editor names * stronger check * adopt `ResourceSet` * no need to coalesce * improve `matches` method
In the previous release we shipped the basic merge editor (release notes). In the release next week, we are going to enable it by default. Please let us know what you think about the new merge editor, so we can continue improving it! |
IntelliJ, and all other IntelliJ-based IDE such as WebStorm, support a git merge's conflict resolution tool that it shows the conflict in three columns:
Please see my attached file.
I find that it's super easy for us to resolve conflict, because I can compare the Local Changes and the Server Changes on the same windows, and I can see the Resolution Result immediately.
Can we please support that?
The text was updated successfully, but these errors were encountered: