Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable Touch Bar controls and leave control strip #38333

Closed
mokyox opened this issue Nov 14, 2017 · 10 comments
Closed

Option to disable Touch Bar controls and leave control strip #38333

mokyox opened this issue Nov 14, 2017 · 10 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded workbench-touchbar Mac touchbar issues
Milestone
January 2018

Comments

@mokyox
Copy link

mokyox commented Nov 14, 2017

I wrote about this already in a closed issue and was recommended to make a new issue instead.

Is there a way users can disable Touch Bar controls and leave the control strip intact? Something like this without the highlighted area.

touch bar shot 2017-11-14 at 11 59 33

At the moment, the only workaround is to force the Touch Bar to display the Fn keys but of course, that means I can't use the control strip.
@vscodebot vscodebot bot added the workbench label Nov 14, 2017
@bpasero bpasero added feature-request Request for new features or functionality workbench-touchbar Mac touchbar issues and removed workbench labels Nov 15, 2017
@bpasero
Copy link
Member

bpasero commented Nov 15, 2017

Currently not.

@bpasero bpasero removed their assignment Nov 15, 2017
@mokyox
Copy link
Author

mokyox commented Nov 15, 2017

@bpasero Thanks for responding. Is there any chance it will be included in a future update? I keep pressing the run command button by accident.

@felipenmoura
Copy link

I like the idea too.
I've been working on a plugin that adds features for the touchbar, but it is limited to 6 buttons because of space.
@bpasero If you can point me the right direction where it is implemented in VSCode source, I can try and open a PR :)

@mokyox
Copy link
Author

mokyox commented Nov 17, 2017 •
edited
Loading

@felipenmoura That would be great! The option to customise the touch bar like many other apps would be very useful.

@felipenmoura
Copy link

Yes, @mokyox . We added this using the user settings.
We couldn't figure out yet, how to customize it with the same design as other apps in mac.
You can give it a try here:
https://marketplace.visualstudio.com/items?itemName=felipe.nasc-touchbar#overview

@mokyox
Copy link
Author

mokyox commented Nov 17, 2017

@felipenmoura Looks good so far! My only recommendation would be to make the icon sizes bigger. Alas, I think me and the touch bar aren't meant to be and I'd rather have it empty at this point.

Also, if @bpasero can point you in the direction of where it is in the code, that would be great.

@felipenmoura
Copy link

thanks, cool.
Yep, I agree about the icons...but VSCode support for icons in touchbar is still very limited, that's why we decided to go for the ascii symbols instead.

@bpasero
Copy link
Member

bpasero commented Nov 18, 2017

A setting could be added around here to prevent the creation of the touchbar: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-browser/window.ts#L322

@bpasero bpasero added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Nov 26, 2017
@viztor
Copy link

viztor commented Dec 17, 2017

can i take this?

@bpasero bpasero self-assigned this Dec 18, 2017
@bpasero bpasero added this to the On Deck milestone Dec 18, 2017
@Baltazore Baltazore mentioned this issue Dec 22, 2017
Merged
@bpasero bpasero modified the milestones: On Deck, December 2017/January 2018 Dec 22, 2017
bpasero pushed a commit that referenced this issue Dec 22, 2017
@Baltazore @bpasero
Option to disable Touch Bar controls and leave control strip (#38333) (…
4ceb6f9 
…#40692)

* ISSUE #38333 Option to disable Touch Bar controls and leave control strip

* Add config option `keyboard.touchbar.enabled` to control macOS touchbar

* Add tracking of `keyboard.touchbar.enabled` option to relauncher service

* Remove duplicate configs
@bpasero bpasero added the verification-needed Verification of issue is requested label Dec 22, 2017
@bpasero bpasero closed this as completed Dec 22, 2017
@bpasero
Copy link
Member

bpasero commented Dec 22, 2017 •
edited
Loading

Verify: via the new keyboard.touchbar.enabled setting on a macOS with touchbar. Install Touchbar Simulator: https://github.com/sindresorhus/touch-bar-simulator

@aeschli aeschli added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded workbench-touchbar Mac touchbar issues
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
5 participants
@felipenmoura @bpasero @viztor @aeschli @mokyox