Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] syntax highlight for 'var' and 'function' not working in Default VS theme #3903

Closed
aeschli opened this issue Mar 9, 2016 · 7 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 9, 2016

0.10.10 (Feburary build) has a regression is that the following JavaScript keywords are no longer highlighted in the Dark Visual Studio & Light Visual Studio themes:
var let const function get set class interface module namespace

This only affects JavaScript (not TypeScript).
The workaround if to switch to the Dark+ Default and Light+ theme.

Note that there are other colorizing issues open, not caused by this regression: e.g. 'import' and 'from'. See microsoft/TypeScript-TmLanguage#37

@Thaina
Copy link

Thaina commented Mar 9, 2016

Not sure if intended but delete is not highlighted too

@aeschli
Copy link
Contributor Author

aeschli commented Mar 9, 2016

'delete' is also microsoft/TypeScript-TmLanguage#37

@aeschli aeschli changed the title [js] syntax highlight for 'var' an 'function' not working in Default VS theme [js] syntax highlight for 'var' and 'function' not working in Default VS theme Mar 10, 2016
@egamma egamma added important Issue identified as high-priority stable-candiate labels Mar 11, 2016
aeschli added a commit that referenced this issue Mar 11, 2016
@aeschli aeschli closed this as completed Mar 11, 2016
@aeschli aeschli assigned weinand and unassigned aeschli Mar 11, 2016
@weinand weinand added the verified Verification succeeded label Mar 11, 2016
@Thaina
Copy link

Thaina commented Mar 15, 2016

delete still not highlighted. Is it intended?

@aeschli
Copy link
Contributor Author

aeschli commented Mar 15, 2016

'delete' is microsoft/TypeScript-TmLanguage#37 and will be fixed in the March release.

@aeschli
Copy link
Contributor Author

aeschli commented Mar 15, 2016

Yesterday, we created a new release that contains the fix for the coloring of var, let, const, function etc.
Please update...

@NickHeiner
Copy link

yield is still not highlighted with version f291f4a. Is that intended?

@nkhanhcong
Copy link

seem like import isn't highlighted

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants