Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tab shrinking overflow differently (no "...", shadow?) #39417

Closed
Tekbr opened this issue Dec 1, 2017 · 8 comments
Closed

Show tab shrinking overflow differently (no "...", shadow?) #39417

Tekbr opened this issue Dec 1, 2017 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded workbench-tabs VS Code editor tab issues
Milestone

Comments

@Tekbr
Copy link

Tekbr commented Dec 1, 2017

  • VSCode Version: 1.19.0-insider (5b0fa2e Date 2017-12-01T06:14:38.596Z )
  • OS Version: Windows 10

-- Sorry for the English, I used Google Translator --

As he talked to @bpasero , he asked to be tracked in a new case. From #15048

Comment @Tekbr #15048

@bpasero An idea ... Instead of using the '...', why not use the style of Microsoft Edge, Mozilla Firefox and Google Chrome? 😉 The text is below the "X" (erased slightly) as the guide decreases.

tab

Particularly, I prefer the style of Firefox.

Comment @bpasero #15048

@Tekbr good suggestions. I am not a big fan of how Edge is simply clipping the text at the end of the tab. I really like what Firefox/Chrome are doing with the fading out in the end, if anyone wants to chime in with a reasonable PR (not too crazy, just CSS), feel free.

What I can change though is to not leave the room for the close button. I realized that when shrinking is enabled, the close button should only show up on hover, but otherwise not consume any space:

33417693-cc896aec-d5a2-11e7-93aa-f6f2b9a33923

Comment @Tekbr #15048

@bpasero Thanks for the feedback!!

I was happy with your move !! 😄 👏 👏

By your comment it seems like something simple to do (or not) 🤔 , but after going through the team tests .. or even before (if you think better) maybe crawl for a new case suggesting for beginners, no? Referring to this case and the test case, with my comment and your comment (if you think you should). That way, someone can locate it more easily! 🤔

Anyway, thanks again for the feedback! 👍

Comment @bpasero #15048

Sure, feel free to create a new issue for it and we can ask for help.

@bpasero If necessary, update the case. Make the necessary modifications / simplifications. (do it please.)

Reproduces without extensions: Yes

@vscodebot vscodebot bot added insiders editor-contrib Editor collection of extras labels Dec 1, 2017
@bpasero bpasero changed the title Remove "..." from tab shrinking Show tab shrinking overflow differently (no "...", shadow?) Dec 1, 2017
@bpasero bpasero added feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues help wanted Issues identified as good community contribution opportunities and removed editor editor-contrib Editor collection of extras labels Dec 1, 2017
@bpasero
Copy link
Member

bpasero commented Dec 1, 2017

Would be willing to look into a reasonable PR for this that is not too crazy. E.g. ideally CSS only change.

Dari-K added a commit to Dari-K/vscode that referenced this issue Dec 6, 2017
@chrmarti chrmarti removed the insiders label Jan 18, 2018
@bpasero bpasero self-assigned this Feb 5, 2018
@bpasero bpasero added this to the February 2018 milestone Feb 5, 2018
@bpasero bpasero closed this as completed in 10e8ce9 Feb 5, 2018
@bpasero
Copy link
Member

bpasero commented Feb 5, 2018

Thanks to @Dari-K, tabs now fade out when set to shrink:

image

@Tekbr
Copy link
Author

Tekbr commented Feb 8, 2018

@bpasero and @Dari-K I really liked it very much .... ❤️ ❤️ ❤️

I delayed responding until I got the Insiders version 1.21.0

Just one question ... do you think this overlap might be a little longer? Put a little more word for word?

Ex: By the image above, in the second tab (image), half of the letter 'g' would also have the shading.
Just to have an idea .. if you could increase.

This would extend to when we hover over and the 'X' appears to close.

Anyway the work was great ... it was good, much better than '...' 😍 Congratulations on the beautiful work. 👏 👏 👏

Thank you!!

@bpasero
Copy link
Member

bpasero commented Feb 8, 2018

Yeah I also thought that the shadow is very subtle, I wouldn't mind expanding it a bit.

@Tekbr
Copy link
Author

Tekbr commented Feb 8, 2018

@bpasero I think it could increase the width between 25 ~ 30px!
What do you think? Would you suggest more or less? 🤔

sombra

sombra

Sorry for the bad image / gif. I modified it by inspecting ...

@bpasero
Copy link
Member

bpasero commented Feb 10, 2018

@Dari-K your call, I think 10px is fine.

@Tekbr
Copy link
Author

Tekbr commented Feb 15, 2018

@bpasero From 5px to 10px there is almost no difference .. at least 15px. What do you think?

@bpasero bpasero added the verification-needed Verification of issue is requested label Feb 23, 2018
@bpasero
Copy link
Member

bpasero commented Feb 23, 2018

Verification:
Configure "workbench.editor.tabSizing": "shrink" and open enough tabs so that they shrink. See a shadow instead of a ellipsis at the end of the tab label. The shadow works fine in light and dark themes.

@RMacfarlane RMacfarlane added the verified Verification succeeded label Feb 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

4 participants