Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs should be in the output panel #39638

Closed
isidorn opened this issue Dec 5, 2017 · 2 comments
Closed

Logs should be in the output panel #39638

isidorn opened this issue Dec 5, 2017 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality log VS Code log issues on-testplan
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 5, 2017

Refs: #39572

Logs are read only and thus shuold be in the output panel imho
They could have a channel (or multiple) of their own which could be shown in the output dropdown.

@isidorn isidorn added the feature-request Request for new features or functionality label Dec 5, 2017
@sandy081 sandy081 self-assigned this Dec 5, 2017
@sandy081 sandy081 added the log VS Code log issues label Dec 5, 2017
@isidorn
Copy link
Contributor Author

isidorn commented Dec 5, 2017

Another issue with the current approach is having to manage editors. Here's what just happened to me: i was inspecting logs, and left the log editor open. I restart vscode with a different log flag to only show errors, vscode opens and I still see the old logs (due to the editor being persisted). Only after I while I figured I need to re-fatch my logs and the shown state is stale

As a simple workaround for this we should close all log editors when a log level changes

@joaomoreno
Copy link
Member

I actually like it better if we put them into the Output pane. 👍

Also fixes #39644

@sandy081 sandy081 added this to the December 2017 milestone Dec 6, 2017
sandy081 added a commit that referenced this issue Dec 18, 2017
@joaomoreno joaomoreno removed their assignment Jan 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality log VS Code log issues on-testplan
Projects
None yet
Development

No branches or pull requests

3 participants