Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git bash history does not record commands. #39877

Closed
juliandavidmr opened this issue Dec 7, 2017 · 2 comments
Closed

Git bash history does not record commands. #39877

juliandavidmr opened this issue Dec 7, 2017 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label windows VS Code on Windows issues
Milestone
Backlog

Comments

@juliandavidmr
Copy link

  • VSCode Version: 1.18.1
  • OS Version: Windows 8.1

Steps to Reproduce:

  1. Ctrl+ñ
  2. Type a command in the git bash opened
  3. Click to trash icon and close git bash tab
  4. Repeat step 1 and 2
  5. Press key up in the keyboard. Note that the command written in step 2 has not been recorded in the gitbash history

This is not a recent problem, it has been for a long time. Nor is it a git bash problem, since all the commands written in the gitbash (not being embedded in vscode) are stored.

Reproduces without extensions: Yes/No
@vscodebot vscodebot bot added the git GIT issues label Dec 7, 2017
@joaomoreno joaomoreno assigned Tyriar and unassigned joaomoreno Dec 7, 2017
@joaomoreno joaomoreno added terminal General terminal issues that don't fall under another label and removed git GIT issues labels Dec 7, 2017
@Tyriar
Copy link
Member

Tyriar commented Dec 11, 2017

This appears to be happening because of the way we forcefully kill the git bash process when killing a terminal. Running exit works just fine. Let me know if anyone has ideas on how to improve.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities windows VS Code on Windows issues labels Dec 11, 2017
@Tyriar Tyriar added this to the Backlog milestone Dec 11, 2017
@Tyriar
Copy link
Member

Tyriar commented Mar 13, 2018

Duplicate #43557

@Tyriar Tyriar closed this as completed Mar 13, 2018
@Tyriar Tyriar added *duplicate Issue identified as a duplicate of another issue(s) and removed help wanted Issues identified as good community contribution opportunities labels Mar 13, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label windows VS Code on Windows issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@joaomoreno @Tyriar @juliandavidmr