Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal should remember the history of commands after VS Code's restart on Windows #43557

Closed
user3323 opened this issue Feb 13, 2018 · 3 comments
Closed

Terminal should remember the history of commands after VS Code's restart on Windows #43557

user3323 opened this issue Feb 13, 2018 · 3 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues windows VS Code on Windows issues

Comments

@user3323
Copy link

  • VSCode Version: 1.21.0-ins
  • OS Version: win7x64

Every time you restart the VS Code - you have to enter the commands again and again.

So, maybe anyone could implement a in-built history for those? It would help a lot!
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Feb 13, 2018
@Bendjen
Copy link

Bendjen commented Feb 13, 2018

Agree ! That is quite useful for me , too.

@alefragnani alefragnani mentioned this issue Feb 18, 2018
Closed
@Tyriar
Copy link
Member

Tyriar commented Feb 21, 2018

This might be happening on Windows because we're forcefully killing all console processes in the process tree when VS Code is shutdown https://github.com/Tyriar/node-pty/blob/ad71e8989d7613e2e439cc191ede6d5e48600f58/src/windowsPtyAgent.ts#L99

Without this sometimes zombie processes would be left over. Perhaps there should be a timeout or something before we kill everything to allow processes to shut down gracefully? It would then depend on how winpty shuts down the processes.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities windows VS Code on Windows issues labels Feb 21, 2018
@Tyriar Tyriar changed the title Feature Request - Terminal should remember the history of commands after VS Code's restart Terminal should remember the history of commands after VS Code's restart on Windows Feb 21, 2018
This was referenced Mar 13, 2018
Closed
Closed
@Tyriar
Copy link
Member

Tyriar commented Sep 12, 2018

This is likely related to winpty, tracking in #45693

@Tyriar Tyriar closed this as completed Sep 12, 2018
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 12, 2018
@Tyriar Tyriar mentioned this issue Sep 24, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues windows VS Code on Windows issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tyriar @Bendjen @user3323