Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new Java/Type-script settings #4022

Closed
2 tasks done
dbaeumer opened this issue Mar 11, 2016 · 2 comments
Closed
2 tasks done

Test new Java/Type-script settings #4022

dbaeumer opened this issue Mar 11, 2016 · 2 comments

Comments

@dbaeumer
Copy link
Member

Assignees:

Items

The following settings have been added for both typescript and javascript:

"typescript.validate.enable": boolean; enabls/disables validation. If set to false no problems should be shown. Make sure the setting updates dynamically

Additional formatter settings: play with them and ensure that the formatter behaves correctly.

"typescript.format.insertSpaceAfterCommaDelimiter": boolean;
"typescript.format.insertSpaceAfterSemicolonInForStatements": boolean;
"typescript.format.insertSpaceBeforeAndAfterBinaryOperators": boolean;
"typescript.format.insertSpaceAfterKeywordsInControlFlowStatements": boolean;
"typescript.format.insertSpaceAfterFunctionKeywordForAnonymousFunctions": boolean;
"typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": boolean;
"typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": boolean;
"typescript.format.placeOpenBraceOnNewLineForFunctions": boolean;
"typescript.format.placeOpenBraceOnNewLineForControlBlocks": boolean;

Also ensure that the settings are independent of their javascript counterpart and apply to their respective mode. E.g.javascript.validate.enable: false and typescript.validate.enable: true is a valid configuration and problems are only shown in TS.

@dbaeumer dbaeumer added this to the March 2016 milestone Mar 11, 2016
@dbaeumer dbaeumer changed the title Test new Java/Type settings Test new Java/Type-script settings Mar 13, 2016
@egamma egamma mentioned this issue Mar 13, 2016
82 tasks
@sofianhn
Copy link

validated javascript/typescript validation options. Still waiting on #3980 for extra formatter options. @dbaeumer please ping me when it's done.

@dbaeumer
Copy link
Member Author

@sofianhn #3980 is done. You can test it with the latest nightly build

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants