Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets not behaving correctly #4279

Closed
sofianhn opened this issue Mar 15, 2016 · 4 comments
Closed

Comments

@sofianhn
Copy link

  1. add "typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": true to the workspace settings.
  2. open a TS file and copy if (x) {var x = 1;}
  3. select the line and format
  4. expected==Actual => if (x) { var x = 1; }
  5. change the option to false.
  6. format again
  7. Actual == if (x) { var x = 1; } but expected if (x) {var x = 1;}
@dbaeumer
Copy link
Member

Moving to TS. We pass the right option to the tsserver.

@dbaeumer
Copy link
Member

This issue was moved to microsoft/TypeScript#7540

@magnushiie
Copy link
Contributor

Now that InsertSpaceAfterOpeningAndBeforeClosingNonemptyBraces have been added to TypeScript, I think this issue should be reopened to add it to VS Code too.

@magnushiie
Copy link
Contributor

Ah, #18043 tracks this, waiting on microsoft/TypeScript#13275

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants