insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets not behaving correctly

[dbaeumer]

From @sofianhn on March 15, 2016 21:7

• VSCode Version: 0.10.12

• OS Version: OSX
  Default initializers on required parameters #4022

  Steps to Reproduce:

1. add "typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": true to the workspace settings.
2. open a TS file and copy if (x) {var x = 1;}
3. select the line and format
4. expected==Actual => if (x) { var x = 1; }
5. change the option to false.
6. format again
7. Actual == if (x) { var x = 1; } but expected if (x) {var x = 1;}

Copied from original issue: microsoft/vscode#4279

[dbaeumer]

Moving to TS. We pass the right option to the tsserver.

[zhengbli]

This is because the tsserver considers only [ and ] as brackets. Therefore this rule is not meant for the described scenario. We could open up new API for { and } (namely braces), but that should be a separate issue.

[bcherny]

@zhengbli What is the correct option to use for {}? Did you guys end up reusing insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets, or is there a separate flag?

[zhengbli]

@bcherny no corresponding rule has been provided. But that should be easy to add, I'll send a PR soon.