Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rule to toggle space after opening brace and before closing brace #10447

Merged
merged 4 commits into from
Sep 6, 2016

Conversation

zhengbli
Copy link
Contributor

Fixes #7540 (Though it is already fixed, it is a popular request that people want to configure whether to add the space or not in the comments).

@@ -1354,6 +1354,7 @@ namespace ts {
InsertSpaceAfterFunctionKeywordForAnonymousFunctions: boolean;
InsertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis: boolean;
InsertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets: boolean;
InsertSpaceAfterOpeningAndBeforeClosingNonemptyBraces: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be optional

@zhengbli
Copy link
Contributor Author

zhengbli commented Sep 6, 2016

Ping @mhegazy

@mhegazy
Copy link
Contributor

mhegazy commented Sep 6, 2016

👍

@zhengbli zhengbli merged commit bef6a66 into microsoft:master Sep 6, 2016
@zhengbli zhengbli deleted the rule branch September 6, 2016 23:15
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets not behaving correctly
3 participants